Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: primitive dry-run mode for mixedversion tests #137963

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

roachtest: primitive dry-run mode for mixedversion tests #137963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cmd/roachtest/roachtestutil/mixedversion/mixedversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ const (
// - MVT_UPGRADE_PATH=24.1.5,24.2.0,current
// - MVT_UPGRADE_PATH=24.1,24.2,current
upgradePathOverrideEnv = "MVT_UPGRADE_PATH"

// Dump the test plan and return, i.e., skipping the actual execution of the test.
dryRunEnv = "MVT_DRY_RUN"
)

var (
Expand Down Expand Up @@ -774,6 +777,11 @@ func (t *Test) Run() {

t.logger.Printf("mixed-version test:\n%s", plan.PrettyPrint())

if override := os.Getenv(dryRunEnv); override != "" {
t.logger.Printf("skipping test run in dry-run mode")
return
}

// Mark the deployment mode and versions, so they show up in the github issue. This makes
// it easier to group failures together without having to dig into the test logs.
t.rt.AddParam("mvtDeploymentMode", string(plan.deploymentMode))
Expand Down
Loading