lib: cockpit: remove cockpit.when() #21268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
Nov 14, 2024
jelly
force-pushed
the
cockpit-when-become
branch
from
8a870cf
to
1a0a208
Compare
martinpitt
changed the title
|
@jelly sorry, this is now conflicty |
Replace the only user of this API with the native Promise equivalent. This API was never publically documented so nothing should depend on it.
jelly
force-pushed
the
cockpit-when-become
branch
from
1a0a208
to
5fa6bed
Compare
Fixed |
martinpitt
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the only user of this API with the native Promise equivalent.