shell: Include state.jsx in type checking #21267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the complexity of the Shell slightly. The build_href function is special in that it constructs a string for a Location object without including the configured URL root of this Cockpit instance. The only point of this is to create strings that can be passed to ShellState.jump. They also show up in href attributes, but they never really should. So, let's never pass a string to ShellState.jump and just pass the Location object directly.
Found by TypeScript. The symptom of the bug is that navigating again to the current location would not be a no-op, but would create a history entry. This seems hard to trigger. Still a bug.
cockpituous
reviewed
Nov 14, 2024
| @@ -130,8 +130,7 @@ export class CockpitHosts extends React.Component { | |||
|
|
|||
| const connection_string = machine.connection_string; | |||
| const parts = split_connection_string(connection_string); | |||
| const addr = build_href({ host: parts.address }); | |||
| state.jump(addr); | |||
| state.jump({ host: parts.address }); | |||
There was a problem hiding this comment.
This added line is not executed by any test.
| @@ -147,8 +146,7 @@ | |||
|
|
|||
| if (current_machine === machine) { | |||
| // Removing machine underneath ourself - jump to localhost | |||
| const addr = build_href({ host: "localhost" }); | |||
| state.jump(addr); | |||
| state.jump({ host: "localhost" }); | |||
There was a problem hiding this comment.
This added line is not executed by any test.
| active={m === current_machine} | ||
| key={m.key} | ||
| name={m.label} | ||
| header={(m.user ? m.user : this.state.current_user) + " @"} | ||
| status={m.state === "failed" ? { type: "error", title: _("Connection error") } : null} | ||
| className={m.state} | ||
| jump={() => this.onHostSwitch(m)} | ||
| onClick={() => this.onHostSwitch(m)} |
There was a problem hiding this comment.
This added line is not executed by any test.
| if (machine == current_machine && parts.address != machine.address) { | ||
| shell_state.loader.connect(parts.address); | ||
| shell_state.jump(addr); | ||
| shell_state.jump({ host: parts.address }); |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+148
to
+152
| <a className="pf-v5-c-nav__section-title nav-item" | ||
| href={encode_location(g.action.target)} | ||
| onClick={ ev => { | ||
| this.props.jump(g.action.target); | ||
| ev.preventDefault(); |
There was a problem hiding this comment.
These 5 added lines are not executed by any test.
| section, | ||
| label: cockpit.gettext(info.label) || prop, | ||
| label: info.label ? cockpit.gettext(info.label) : prop, |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+207
to
+208
| if (comp && comp.parent && comp.parent.component) | ||
| component = comp.parent.component as string; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| }; | ||
| const item = this.items.get(component); | ||
| if (item) | ||
| return item; |
There was a problem hiding this comment.
This added line is not executed by any test.
| checksum: string; | ||
| } | ||
|
|
||
| function component_checksum(machine: Machine, path: string): string | undefined { |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+329
to
+331
| const p = parseInt(conn_to.substring(port_spot + 1), 10); | ||
| if (!isNaN(p)) { | ||
| port = p; |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
|
Nope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimum effort to get test/static-code to find errors in ShellState. It doesn't do anything for users of ShellState.