metrics: collect disk usage from internal metrics #21062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun times, you forget one important detail, the JS code filters mount points (loopback, flatpak, and? tmpfs?) |
tomasmatus
force-pushed
the
port-mountpoints-internal-metrics
branch
from
ad6a56d
to
e692d9d
Compare
jelly
reviewed
Oct 3, 2024
src/cockpit/samples.py
Outdated
| path = line.split()[1] | ||
| split_line = line.split() | ||
| # Skip read-only loop mounts | ||
| if '/loop' in split_line[0] and 'ro' in split_line[3].split(','): |
There was a problem hiding this comment.
Wouldn't it be nicer to properly decompose this
mounts = open('/proc/mounts').read()
fs_spec, fs_file, fs_vfstype, fs_mntopts, *_rest = mounts.splitlines()[0].split()Not sure if one can remove *_rest, field definitions comes from https://man.archlinux.org/man/fstab.5
use `mount.total` and `mount.used` from internal metrics instead of parsing `df` output.
tomasmatus
force-pushed
the
port-mountpoints-internal-metrics
branch
from
e692d9d
to
b1511a7
Compare
|
The anaconda test failures are unrelated and already fixed in anaconda-webui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
mount.totalandmount.usedfrom internal metrics instead of parsingdfoutput.