Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login: Prevent multiple logins in a single browser session #20860

Merged
merged 2 commits into from
Aug 20, 2024
Merged

login: Prevent multiple logins in a single browser session #20860

merged 2 commits into from
Aug 20, 2024

Commits on Aug 13, 2024

  1. test: Remove ineffective config change in check-embed 

    Changing the Shell= setting back without restarting cockpit has no
effect.
    @mvollmer
    mvollmer committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0a74fdb View commit details
    Browse the repository at this point in the history

  2. login: Prevent multiple logins in a single browser session 

    unless allowed by cockpit.conf.

If the login page is loaded and a valid session cookie is already
available, then we are about to log into a second host from the same
browser session, and both logins will have access to each others
cookies. This should only be allowed when AllowMultiHost is true. If
it is not true, the login page immediately redirects to the session
for the existing cookie.

Information about session cookies is not available to login.js, so
cockpit-ws helps out by exposing which ones are present, without
exposing the cookies themselves.
    @mvollmer
    mvollmer committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1dd4eca View commit details
    Browse the repository at this point in the history