Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use become_superuser helper for switching access #19593

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test: use become_superuser helper for switching access #19593

merged 1 commit into from
Nov 9, 2023

Conversation

jelly
Copy link
Member

@jelly jelly commented Nov 9, 2023

No description provided.

martinpitt
martinpitt approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it doesn't fix the flake, this is nice cleanup.

@jelly
Copy link
Member Author

jelly commented Nov 9, 2023

Even if it doesn't fix the flake, this is nice cleanup.

This is unrelate to the testSOS.testBasic flake, just a general cleanup I noticed

@jelly jelly marked this pull request as ready for review November 9, 2023 09:49
martinpitt
martinpitt requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually fix the test

@jelly jelly force-pushed the system-realms-superuser-helper branch from eafe447 to 13536e4 Compare November 9, 2023 11:12
@jelly jelly requested a review from martinpitt November 9, 2023 11:12
martinpitt
martinpitt approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! Had to retry a few unrelated flakes.

@jelly jelly merged commit b76a50f into cockpit-project:main Nov 9, 2023
91 checks passed
@jelly jelly deleted the system-realms-superuser-helper branch November 9, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @martinpitt