Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update reference-image to Fedora-39 #19581

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test: update reference-image to Fedora-39 #19581

merged 1 commit into from
Nov 9, 2023

Conversation

jelly
Copy link
Member

@jelly jelly commented Nov 7, 2023 •
edited
Loading

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Nov 8, 2023
@jelly jelly marked this pull request as ready for review November 9, 2023 11:16
martinpitt
martinpitt approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Why are there so many new screenshots for TestStorageLvm2-testRaid? I suppose because that didn't yet work on F38?

@jelly
Copy link
Member Author

jelly commented Nov 9, 2023

Thanks! Why are there so many new screenshots for TestStorageLvm2-testRaid? I suppose because that didn't yet work on F38?

@mvollmer and I forgot to realize that those tests didn't run on Fedora-38 when we merged that new feature.

@martinpitt martinpitt merged commit 63a6b45 into cockpit-project:main Nov 9, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

@mvollmer mvollmer Awaiting requested review from mvollmer

Assignees
No one assigned
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @martinpitt