lib: Don't show icon unless 'icon' prop is passed #19252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
Aug 28, 2023
As per patternfly guidelines [1], validation text (which is main use of FormHelper) should not have an icon [1] https://www.patternfly.org/components/forms/form/design-guidelines/#errors-and-validation
skobyda
force-pushed
the
formHelperValidationIcon
branch
from
81b29bd
to
64522bb
Compare
martinpitt
changed the title
martinpitt
approved these changes
Aug 29, 2023
martinpitt
pushed a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Aug 31, 2023
Update pixel tests for change from cockpit-project/cockpit#19252 Closes #1194
martinpitt
pushed a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Aug 31, 2023
Update pixel tests for change from cockpit-project/cockpit#19252 Closes #1194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per patternfly guidelines [1], validation text (which is main use of FormHelper) should not have an icon
[1] https://www.patternfly.org/components/forms/form/design-guidelines/#errors-and-validation