storage: StorageBarMenu dropdown should not always be plain

[leomoty]

So this partially contributes to #19241

How it looks without plain:

How it looked before:

---

I am not entirely sure why plain was working like that in light mode? but the dark mode was correct (no background/border).

Also the side effect of this change is now that it is using the proper width / slimmer profile as shown by patternfly docs.

[martinpitt]

Thanks! @mvollmer , can you have a look ? I started the f38/storage tests to get the updated pixels

[mvollmer]

I can't say why we used isPlain to begin with, tbh... probably to get the kebab variant to look right.

Removing isPlain has two problems:

• The narrower button looks out of place with regard to toher buttons:

• The kebab version looks wrong:

[mvollmer]

I am surprised that even with isPlain we do get the blue background. Hmm.

[leomoty]

Let me know if the proposed css change is acceptable, it uses the same padding as present elsewhere

[mvollmer]

Let me know if the proposed css change is acceptable, it uses the same padding as present elsewhere

I can't say I understand how Patternfly wants this to work... nor do I care about CSS very much, so I am fine with this. :-)

[mvollmer]

Result looks good to me.

[mvollmer]

Thanks! Let's run the tests!

[leomoty]

@mvollmer seems like we have pixel tests changes, can you do those for me? I don't have the proper setup to get the VMs running at the moment

[martinpitt]

Thanks @leomoty ! I pushed the updated pixel test, it looks great and confirms the fix.

[martinpitt]

Only re-triggering the f38 tests (pixels), the rest already succeeded in the previous round.