Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: Drop i386 clang check-memory #19228

Merged
merged 2 commits into from
Aug 24, 2023
Merged

workflows: Drop i386 clang check-memory #19228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
332ee3b
containers/unit-tests: Don't break verbatim command
martinpitt Aug 23, 2023
e482209
workflows: Drop i386 clang check-memory
martinpitt Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/unit-tests-refresh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,10 @@ jobs:
timeout-minutes: 10
run: containers/unit-tests/build

- name: Run pytest-cov test
timeout-minutes: 15
run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make pytest-cov

- name: Run amd64 gcc check-memory test
timeout-minutes: 20
run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make check-memory

- name: Run i386 clang check-memory test
timeout-minutes: 20
# HACK: https://bugs.kde.org/show_bug.cgi?id=452758
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was i386 only! I checked and thought it would be clang 14 issue and as Debian wasn't updated yet to something newer we couldn't remove it. But seems I'm wrong \o/

run: containers/unit-tests/start --verbose --env=CC=clang --env=CFLAGS='-O2 -gdwarf-4' --image-tag=i386 --make check-memory

- name: Run amd64 clang distcheck test
timeout-minutes: 15
run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=latest --make distcheck
Expand All @@ -45,6 +36,10 @@ jobs:
timeout-minutes: 15
run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=i386 --make distcheck

- name: Run pytest-cov test
timeout-minutes: 15
run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make pytest-cov

- name: Log into container registry
run: podman login -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }} ghcr.io

Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ jobs:
strategy:
matrix:
startarg:
- { make: 'check-memory', cc: 'clang', tag: 'i386' }
# avoid check-memory on i386, it has literally thousands of uninteresting/wrong errors
- { make: 'check-memory', cc: 'gcc', tag: 'latest' }
- { make: 'distcheck', cc: 'clang', tag: 'latest' }
- { make: 'distcheck', cc: 'gcc', tag: 'i386' }
martinpitt marked this conversation as resolved.
Show resolved Hide resolved
- { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
# this runs static code checks, unlike distcheck
- { make: 'check', cc: 'gcc', tag: 'latest' }
- { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
fail-fast: false
timeout-minutes: 60
steps:
Expand Down
8 changes: 4 additions & 4 deletions containers/unit-tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Cockpit unit test container

This container has all build dependencies and toolchains (GCC and clang) that
we want to exercise Cockpit with, mostly for `make distcheck` and `make
check-memory`. This container runs on [GitHub](.github/workflows/unit-tests.yml),
but can be easily run locally too.
This container has all build dependencies and toolchains (GCC and clang) that we
want to exercise Cockpit with, mostly for `make distcheck` and `make check-memory`.
This container runs on [GitHub](.github/workflows/unit-tests.yml), but can be easily
run locally too.

It assumes that the Cockpit source git checkout is available in `/source`. It
will not modify that directory or take uncommitted changes into account, but it
Expand Down
Loading