Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo with arguments is apparently not POSIX :-) #19226

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

jelly
Copy link
Member

@jelly jelly commented Aug 23, 2023

No description provided.

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Aug 23, 2023
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me for the changes, of course.

Let's discuss what to do about i386 in the meeting.

@martinpitt
Copy link
Member

I landed the unbreaking of unit-tests refresh, so this should work now. I retried the tests, but I just realized that it's not gonna work -- you need to rebase.

@martinpitt
Copy link
Member

Anyway, we don't care about clang/i386/valgrind any more, I just land this.

@martinpitt martinpitt merged commit 9932e73 into cockpit-project:main Aug 24, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants