Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Implement missing .pf-v5-u-font-weight-light #19218

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

skobyda
Copy link
Contributor

@skobyda skobyda commented Aug 22, 2023

Patternfly is missing implementation for .pf-v5-u-font-weight-light. Use our own implementation in overrides until [1] is fixed

[1] patternfly/patternfly#5855

Patternfly is missing implementation for .pf-v5-u-font-weight-light.
Use our own implementation in overrides until [1] is fixed

[1] patternfly/patternfly#5855
@skobyda skobyda requested a review from garrett August 22, 2023 11:05
@martinpitt
Copy link
Member

/packit retest-failed

@martinpitt
Copy link
Member

LGTM, but leaving final word to @garrett. I retriggered the tests, they failed on the recent tuned regression, but we have a naughty for that now.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, this looks quite obvious to me, so +1 to reduce Garrett's queue a bit.

@martinpitt
Copy link
Member

I just land this to unblock you. Garrett is overworked and on PTO now-ish, and this looks easy enough that I'm happy to take the bullet.

@martinpitt martinpitt merged commit 6b3e5bc into cockpit-project:main Aug 24, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants