test: add a document describing Cockpit's test Architecture #19177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
jelly
commented
Aug 4, 2023
martinpitt
requested changes
Aug 7, 2023
jelly
force-pushed
the
test-architecture-doc
branch
from
b9f9291
to
474e70b
Compare
|
@jelly Most of my earlier review items are still outstanding. You may have not seen them as they are (unhelpfully) hidden behind an expander? |
jelly
force-pushed
the
test-architecture-doc
branch
from
ae29be6
to
74ef124
Compare
Sorry, I saw them now I hope I've addressed everything. Edit: something which is missing is dropping |
|
@martinpitt gentle reminder |
martinpitt
requested changes
Aug 31, 2023
jelly
force-pushed
the
test-architecture-doc
branch
from
74ef124
to
367dad0
Compare
rjarry
reviewed
Sep 1, 2023
test/ARCHITECTURE.md
Outdated
| The test runner inspects all `running_tests` in a tight loop and polls if the | ||
| test is still running. If the process stopped or exited the test output and | ||
| `returncode` is saved. Depending on the `returncode` the test runner makes a | ||
| decision on what to do next as described in the diagram below. |
There was a problem hiding this comment.
Hi Jelle,
I believe this should be rephrased as:
decision on what to do next as described in the [flow chart](https://xkcd.com/518/) below:;)
jelly
force-pushed
the
test-architecture-doc
branch
2 times, most recently
from
c23130a
to
e0cda54
Compare
martinpitt
requested changes
Sep 12, 2023
jelly
force-pushed
the
test-architecture-doc
branch
from
036094c
to
5da0738
Compare
jelly
force-pushed
the
test-architecture-doc
branch
2 times, most recently
from
c2145c1
to
f0976b3
Compare
jelly
force-pushed
the
test-architecture-doc
branch
from
f0976b3
to
0ec5feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's not to long 😄
A nicely rendered document can be viewed here