Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Check configuring manual IPv6 address #19131

Merged
merged 1 commit into from
Jul 27, 2023
Merged

test: Check configuring manual IPv6 address #19131

merged 1 commit into from
Jul 27, 2023

Conversation

subhoghoshX
Copy link
Member

@subhoghoshX subhoghoshX commented Jul 24, 2023 •
edited by martinpitt
Loading

Also strenghten the IPv4 assertions.

@martinpitt martinpitt marked this pull request as draft July 24, 2023 15:59
@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jul 26, 2023
@martinpitt martinpitt changed the title (ignore) network: testing the reliability of IPv6 settings test: Check configuring manual IPv6 address Jul 26, 2023
@martinpitt
Copy link
Member

@subhoghoshX Thanks for finding this! I updated the commit to strengthen the assertions (also for IPv4), that's the one that we want to eventually land. Plus a second commit to debug this particular test (which is temporary of course). Then we can hopefully write a command line/busctl reproducer, report it as a NetworkManager bug, and add a naughty.

@martinpitt
Copy link
Member

I strengthened the IPv4 assertions some more, to ensure that the IPv4 address also appears in ip a. I can easily reproduce the IPv6 failure, but they do appear a bit afterwards. So the update just happens asynchronously. I adjusted the test accordingly.

@martinpitt
Copy link
Member

Yup, that works fine, see statuses on commit cf858f9. Dropping the extra debug commit, and making this ready for landing.

@subhoghoshX @martinpitt
test: Check configuring manual IPv6 address
3ae872a 
Also strenghten the IPv4 assertions.
@martinpitt martinpitt removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jul 26, 2023
@martinpitt martinpitt marked this pull request as ready for review July 26, 2023 09:14
@martinpitt martinpitt requested a review from jelly July 26, 2023 09:14
@martinpitt
Copy link
Member

As I changed this heavily, @jelly can you please do the final review?

@martinpitt martinpitt requested a review from skobyda July 27, 2023 05:12
@jelly jelly merged commit 3918acc into cockpit-project:main Jul 27, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

@skobyda skobyda Awaiting requested review from skobyda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subhoghoshX @martinpitt @jelly