storage: Managed filesystem sizes #18867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
the
no-test
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
3 times, most recently
from
6535535
to
7803b22
Compare
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
2 times, most recently
from
0b4d1de
to
30d1643
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
3 times, most recently
from
a1cce29
to
68c3b58
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
from
68c3b58
to
85619e5
Compare
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
from
85619e5
to
20a5ddb
Compare
jelly
reviewed
Aug 8, 2023
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
5 times, most recently
from
b914dd1
to
d3ce589
Compare
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
from
d4ea929
to
7cac847
Compare
mvollmer
added
the
no-test
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
from
7cac847
to
fb20dac
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
storage-stratis-managed-filesystems
branch
from
fb20dac
to
c85fe39
Compare
cockpituous
reviewed
Aug 23, 2023
| client.stratis_create_filesystem = (pool, name) => { | ||
| return pool.CreateFilesystems([[name, [false, ""]]]); | ||
| client.stratis_create_filesystem = (pool, name, size) => { | ||
| return pool.CreateFilesystems([[name, size ? [true, size.toString()] : [false, ""]]]); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
Comment on lines
+145
to
+149
| title: (pool.Overprovisioning | ||
| ? <StorageUsageBar stats={[Number(fs.Used[0] && Number(fs.Used[1])), pool_total]} | ||
| critical={1} total={total} offset={offsets[i]} /> | ||
| : <StorageUsageBar stats={[Number(fs.Used[0] && Number(fs.Used[1])), Number(fs.Size)]} | ||
| critical={0.95} /> |
There was a problem hiding this comment.
These 5 added lines are not executed by any test. Details
| let fsys_total_size = 0; | ||
| filesystems.forEach(fs => { | ||
| offsets.push(fsys_total_used); | ||
| fsys_total_used += fs.Used[0] ? Number(fs.Used[1]) : 0; |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| fsys_total_size += Number(fs.Size); | ||
| }); | ||
|
|
||
| const overhead = pool.TotalPhysicalUsed[0] ? (Number(pool.TotalPhysicalUsed[1]) - fsys_total_used) : 0; |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -129,13 +129,13 @@ export function create_stratis_pool(client) { | |||
| }, | |||
| spaces: get_available_spaces(client) | |||
| }), | |||
| CheckBoxes("encrypt_pass", client.features.stratis_crypto_binding ? _("Encryption") : "", | |||
| CheckBoxes("encrypt_pass", client.features.stratis_crypto_binding ? _("Options") : "", | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
jelly
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://youtu.be/5W7g-tYFmqw
Storage: Support for no-overprovisioning with Stratis
A Stratis pool can be put into a "no-overprovisioning" mode where the bad effects of running out of space can be avoided via careful management of filesystem sizes. Cockpit now supports this mode.