Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Allow adding cache to encrypted pools #18852

Merged
merged 2 commits into from
Aug 11, 2023
Merged

storage: Allow adding cache to encrypted pools #18852

merged 2 commits into from
Aug 11, 2023

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented May 26, 2023 •
edited
Loading

This requires moving to "r5" of the D-Bus API.

Storage: Cockpit can now add caches to encrypted Stratis pools

Encrypted caches are a new feature in Stratis 3.5, and now you can use it also from Cockpit.

@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch 2 times, most recently from 7c258f2 to 64d2a2f Compare June 5, 2023 12:14
@mvollmer mvollmer marked this pull request as ready for review June 5, 2023 12:17
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch 2 times, most recently from 9718ac3 to 05bdefb Compare June 6, 2023 10:47
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch from 05bdefb to 26f530e Compare June 6, 2023 12:49
@mvollmer mvollmer added the blocked Don't land until something else happens first (see task list) label Jul 5, 2023
@mvollmer
Copy link
Member Author

mvollmer commented Jul 5, 2023

Let's wait for our arch image to also have stratis 3.5.

@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch 2 times, most recently from bdda685 to e5545ae Compare July 5, 2023 08:12
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch from e5545ae to 4f51d6b Compare July 6, 2023 09:04
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch 2 times, most recently from e0edccf to b494dbc Compare August 8, 2023 16:08
@mvollmer mvollmer removed the blocked Don't land until something else happens first (see task list) label Aug 8, 2023
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch 2 times, most recently from cb12000 to 7f360e1 Compare August 9, 2023 10:25
@mvollmer
test: Check that dropdown options are enabled
388b565 
Just setting the value of the <select> element will always succeed,
even when the option itself is disabled.
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch from 7f360e1 to 5db0e12 Compare August 10, 2023 14:02
@mvollmer mvollmer requested a review from jelly August 10, 2023 14:06
jelly
jelly reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, there are some tests failing and pixels to be updated. It also lacks a release-note

@mvollmer
Copy link
Member Author

The "testing-farm" checks seem to be stuck. I don't know how to get them unstuck other than pushing the PR again.

@jelly
Copy link
Member

jelly commented Aug 11, 2023

The "testing-farm" checks seem to be stuck. I don't know how to get them unstuck other than pushing the PR again.

Approved, tests are still running on the testing farm so let's wait :)

@mvollmer
Copy link
Member Author

Approved, tests are still running on the testing farm so let's wait :)

They are "running" since yesterday evening... :-/

@jelly
Copy link
Member

jelly commented Aug 11, 2023

Approved, tests are still running on the testing farm so let's wait :)

They are "running" since yesterday evening... :-/

 Packit-as-a-Service / testing-farm:fedora-38-x86_64:revdeps Started 2023-08-10 20:03:48 ago

Welp

@mvollmer
storage: Allow adding cache to encrypted pools
fe4aaa3 
This requires moving to "r5" of the D-Bus API.
@mvollmer mvollmer force-pushed the storage-stratis-encrypted-caches branch from 5db0e12 to fe4aaa3 Compare August 11, 2023 08:33
@mvollmer
Copy link
Member Author

I don't know how to get them unstuck other than pushing the PR again.

I pushed again.

@mvollmer
Copy link
Member Author

I think TFTF is stuck again. The build in Copr as succeeded, but something is still waiting for them. We got a couple of greens for the fine testing farm, so this is good to be merged, IMO.

@mvollmer mvollmer merged commit 0d07f76 into cockpit-project:main Aug 11, 2023
29 of 35 checks passed
@martinpitt martinpitt mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvollmer @jelly @martinpitt