workflows: Drop i386 clang check-memory

In recent Debian testing, valgrind now shows a gazillion
Memcheck:{Cond,Value4} errors all over the place: in GMP, GnuTLS, glib
hashtables, and even strcmp(). Give up at last, and run valgrind on 64
bit only. This also becomes less important with us moving more and more
code away from C.

Add a comment about the explicit "check" run. It was introduced in
commit 1ef0001 to run static code checks, which don't work against a
tarball in "distcheck".

Change the order in unit-tests-refresh.yml to match the order in
unit-tests.yml to reduce confusion.

.github/workflows/unit-tests-refresh.yml

@@ -24,19 +24,10 @@ jobs:
         timeout-minutes: 10
         run: containers/unit-tests/build
 
-      - name: Run pytest-cov test
-        timeout-minutes: 15
-        run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make pytest-cov
-
       - name: Run amd64 gcc check-memory test
         timeout-minutes: 20
         run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make check-memory
 
-      - name: Run i386 clang check-memory test
-        timeout-minutes: 20
-        # HACK: https://bugs.kde.org/show_bug.cgi?id=452758
-        run: containers/unit-tests/start --verbose --env=CC=clang --env=CFLAGS='-O2 -gdwarf-4' --image-tag=i386 --make check-memory
-
       - name: Run amd64 clang distcheck test
         timeout-minutes: 15
         run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=latest --make distcheck
@@ -45,6 +36,10 @@ jobs:
         timeout-minutes: 15
         run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=i386 --make distcheck
 
+      - name: Run pytest-cov test
+        timeout-minutes: 15
+        run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make pytest-cov
+
       - name: Log into container registry
         run: podman login -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }} ghcr.io
 

.github/workflows/unit-tests.yml

@@ -7,12 +7,13 @@ jobs:
     strategy:
       matrix:
         startarg:
-          - { make: 'check-memory', cc: 'clang', tag: 'i386' }
+          # avoid check-memory on i386, it has literally thousands of uninteresting/wrong errors
           - { make: 'check-memory', cc: 'gcc', tag: 'latest' }
           - { make: 'distcheck', cc: 'clang', tag: 'latest' }
           - { make: 'distcheck', cc: 'gcc', tag: 'i386' }
-          - { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
+          # this runs static code checks, unlike distcheck
           - { make: 'check', cc: 'gcc', tag: 'latest' }
+          - { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
       fail-fast: false
     timeout-minutes: 60
     steps: