Skip to content

Commit

Permalink
package.json: Revert to sass 1.79
Browse files Browse the repository at this point in the history
sass 1.80 (and 2.x) introduces tons of "@import rules are deprecated".
These are unfixable on our side due to PatternFly using them
extensively.

We don't need any new sass features, so stick to 1.79.x. Explicitly not
ignore 3.x (which will drop @import) to get a reminder in the future to
try and clean this up again.

Fixes #21151
  • Loading branch information
martinpitt committed Oct 23, 2024
1 parent bfc4a81 commit de08dfd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ updates:
xterm:
patterns:
- "@xterm/*"
ignore:
# https://github.com/cockpit-project/cockpit/issues/21151
- dependency-name: "sass"
- versions: ["1.80.x", "2.x"]

- package-ecosystem: "github-actions"
directory: "/"
Expand Down
2 changes: 1 addition & 1 deletion node_modules
Submodule node_modules updated 1206 files
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"jed": "1.1.1",
"qunit": "2.22.0",
"qunit-tap": "1.5.1",
"sass": "1.80.3",
"sass": "1.79.6",
"sizzle": "2.3.10",
"stylelint": "16.10.0",
"stylelint-config-recommended-scss": "14.0.0",
Expand Down

0 comments on commit de08dfd

Please sign in to comment.