Skip to content

Commit

Permalink
lib: Give secondary buttons more contrast in toolbars
Browse files Browse the repository at this point in the history
Secondary buttons have a transparent background by default, which
needs more contrast on grey backgrounds like in toolbars.
  • Loading branch information
mvollmer committed Dec 13, 2024
1 parent ab2d7be commit b268d77
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions pkg/lib/patternfly/patternfly-5-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -407,3 +407,14 @@ select.pf-v5-c-form-control {
html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) {
background-color: var(--pf-v5-global--BackgroundColor--100);
}

/* Give secondary buttons a white/grey background instead of their
default transparent one. This gives them better contrast in
toolbars.
*/
.pf-v5-c-button.pf-m-secondary {
background-color: var(--pf-v5-global--BackgroundColor--100);
.pf-v5-theme-dark & {
background-color: var(--pf-v5-global--BackgroundColor--400);
}
}
2 changes: 1 addition & 1 deletion test/reference
Submodule reference updated 50 files
+ TestAccounts-testBasic-user-detail-page-dark-pixels.png
+ TestAccounts-testBasic-user-detail-page-medium-pixels.png
+ TestAccounts-testBasic-user-detail-page-mobile-pixels.png
+ TestAccounts-testBasic-user-detail-page-pixels.png
+ TestAccounts-testBasic-user-detail-page-rtl-pixels.png
+ TestAccounts-testBasic-users-page-dark-pixels.png
+ TestHostSwitching-testBasic-edit-hosts-dark-pixels.png
+ TestHostSwitching-testBasic-edit-hosts-medium-pixels.png
+ TestHostSwitching-testBasic-edit-hosts-mobile-pixels.png
+ TestHostSwitching-testBasic-edit-hosts-pixels.png
+ TestHostSwitching-testBasic-edit-hosts-rtl-pixels.png
+ TestHostSwitching-testBasic-nav-hosts-2-remotes-dark-pixels.png
+ TestHostSwitching-testBasic-nav-hosts-2-remotes-medium-pixels.png
+ TestHostSwitching-testBasic-nav-hosts-2-remotes-mobile-pixels.png
+ TestHostSwitching-testBasic-nav-hosts-2-remotes-pixels.png
+ TestHostSwitching-testBasic-nav-hosts-2-remotes-rtl-pixels.png
+ TestJournal-testBasic-journal-filters-panel-dark-pixels.png
+ TestJournal-testBasic-journal-filters-panel-medium-pixels.png
+ TestJournal-testBasic-journal-filters-panel-pixels.png
+ TestJournal-testBasic-journal-filters-panel-rtl-pixels.png
+ TestKeys-testPrivateKeys-ssh-keys-dialog-dark-pixels.png
+ TestKeys-testPrivateKeys-ssh-keys-dialog-pixels.png
+ TestNetworkingBasic-testBasic-network-main-dark-pixels.png
+ TestNetworkingBasic-testBasic-network-main-pixels.png
+ TestNetworkingSettings-testNoConnectionSettings-network-ip-settings-dialog-dark-pixels.png
+ TestSelinux-testTroubleshootAlerts-selinux-dark-pixels.png
+ TestServices-testBasic-details-test-fail-dark-pixels.png
+ TestStorageBasic-testBasic-filesystem-dark-pixels.png
+ TestStorageBasic-testBasic-partition-dark-pixels.png
+ TestStorageLuks-testLuks-card-dark-pixels.png
+ TestStorageLuks-testLuks-card-medium-pixels.png
+ TestStorageLuks-testLuks-card-mobile-pixels.png
+ TestStorageLuks-testLuks-card-pixels.png
+ TestStorageLuks-testLuks-card-rtl-pixels.png
+ TestStorageLuks-testLuks-format-dark-pixels.png
+ TestStorageLvm2-testLvm-page-dark-pixels.png
+ TestStorageLvm2-testLvm-page-medium-pixels.png
+ TestStorageLvm2-testLvm-page-pixels.png
+ TestStorageLvm2-testLvm-page-rtl-pixels.png
+ TestStorageLvm2-testLvm-pool-page-dark-pixels.png
+ TestStorageLvm2-testRaid-raid5-card-dark-pixels.png
+ TestStorageLvm2-testRaid-raid5-card2-dark-pixels.png
+ TestStorageMdRaid-testRaid-page-dark-pixels.png
+ TestStorageStratis-testBasic-copy-fsys-dark-pixels.png
+ TestStorageStratis-testBasic-create-fsys-dark-pixels.png
+ TestStorageStratis-testBasic-fsys-rows-dark-pixels.png
+ TestStorageStratisNBDE-testBasic-header-dark-pixels.png
+ TestStorageUsed-testUsed-format-dark-pixels.png
+ TestTerminal-testBasic-header-dark-pixels.png
+ TestWireGuard-testVPN-networking-wireguard-add-generated-dark-pixels.png

0 comments on commit b268d77

Please sign in to comment.