Skip to content

Commit

Permalink
test: allow direct rendering to body warnings
Browse files Browse the repository at this point in the history
React discourages rendering directly to `document.body` as its children
might be manipulated by other third-party scripts. We used to render to
body directly in machines, but currently this is no longer true and all
our pages should also render to a <div> inside <body>.
  • Loading branch information
jelly committed Feb 28, 2024
1 parent 22e140c commit a39755f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/common/chromium-cdp-driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ function setupLogging(client) {
if (details.exception && details.exception.className === "PhWaitCondTimeout")
return;

// HACK: https://github.com/cockpit-project/cockpit/issues/14871
if (details.description && details.description.indexOf("Rendering components directly into document.body is discouraged") > -1)
return;

process.stderr.write(details.description || JSON.stringify(details) + "\n");

unhandledExceptions.push(details.exception.message ||
Expand Down

0 comments on commit a39755f

Please sign in to comment.