Skip to content

Commit

Permalink
workflows: Move i386 clang check-memory run to amd64
Browse files Browse the repository at this point in the history
In recent Debian testing, valgrind now shows a gazillion
Memcheck:{Cond,Value4} errors all over the place: in GMP, GnuTLS, glib
hashtables, and even strcmp().

Give up at last, and run valgrind on 64 bit only. This also becomes less
important with us moving more and more code away from C.
  • Loading branch information
martinpitt committed Aug 23, 2023
1 parent 568caa7 commit 6420297
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/unit-tests-refresh.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ jobs:
timeout-minutes: 20
run: containers/unit-tests/start --verbose --env=CC=gcc --image-tag=latest --make check-memory

- name: Run i386 clang check-memory test
- name: Run amd64 clang check-memory test
timeout-minutes: 20
# HACK: https://bugs.kde.org/show_bug.cgi?id=452758
run: containers/unit-tests/start --verbose --env=CC=clang --env=CFLAGS='-O2 -gdwarf-4' --image-tag=i386 --make check-memory
run: containers/unit-tests/start --verbose --env=CC=clang --env=CFLAGS='-O2 -gdwarf-4' --image-tag=latest --make check-memory

- name: Run amd64 clang distcheck test
- name: Run i386 clang distcheck test
timeout-minutes: 15
run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=latest --make distcheck
run: containers/unit-tests/start --verbose --env=CC=clang --image-tag=i386 --make distcheck

- name: Run i386 gcc distcheck test
timeout-minutes: 15
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
strategy:
matrix:
startarg:
- { make: 'check-memory', cc: 'clang', tag: 'i386' }
- { make: 'check-memory', cc: 'clang', tag: 'latest' }
- { make: 'check-memory', cc: 'gcc', tag: 'latest' }
- { make: 'distcheck', cc: 'clang', tag: 'latest' }
- { make: 'distcheck', cc: 'clang', tag: 'i386' }
- { make: 'distcheck', cc: 'gcc', tag: 'i386' }
- { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
- { make: 'check', cc: 'gcc', tag: 'latest' }
Expand Down

0 comments on commit 6420297

Please sign in to comment.