Hide container/image Command details for quadlets #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but this isn't specific to quadlets, right? other container images may also not have a command. Can you please add a test? |
Sure, will do tomorrow. Basically for images the issue was that the Cmd was |
Quadlets have an `EntryPoint` and no `Command` so for quadlets we would have shown an empty `Command` which isn't terribly useful or informative.
jelly
force-pushed
the
quadlet-cmd-absent
branch
from
646ec11 to
3d5c52e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quadlets have an
EntryPointand noCommandso for quadlets we would have shown an emptyCommandwhich isn't terribly useful or informative.Before: