Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1484

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0afe6df
test: Fix dialog closing
martinpitt Nov 16, 2023
9cc6ce7
Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db
cockpituous Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ COCKPIT_REPO_FILES = \
$(NULL)

COCKPIT_REPO_URL = https://github.com/cockpit-project/cockpit.git
COCKPIT_REPO_COMMIT = 5ec1a3ad4c1b544c9935b680333b07d54f42661e # 304 + 29 commits
COCKPIT_REPO_COMMIT = 140b7e62f5cfcad5ad9105867474526ef68351db # 305 + 9 commits

$(COCKPIT_REPO_FILES): $(COCKPIT_REPO_STAMP)
COCKPIT_REPO_TREE = '$(strip $(COCKPIT_REPO_COMMIT))^{tree}'
Expand Down
6 changes: 5 additions & 1 deletion test/check-application
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,8 @@ class TestApplication(testlib.MachineCase):
b.click("#create-image-image-select-typeahead")
b.wait_visible(f".pf-v5-c-select__menu-item:contains('{IMG_REGISTRY}')")
b.wait_not_present(".pf-v5-c-select__menu-item:contains('none')")
b.click(".pf-v5-c-modal-box .btn-cancel")
b.wait_not_present(".pf-v5-c-modal-box")

def testCommitUser(self):
self._testCommit(False)
Expand Down Expand Up @@ -1052,18 +1054,20 @@ class TestApplication(testlib.MachineCase):
b.click(f".pf-v5-c-data-list .image-name:contains({self.imageName})")
b.wait_visible("div.pf-v5-c-modal-box footer button:contains(Download):not([disabled])")
b.click("div.pf-v5-c-modal-box footer button:contains(Download)")
b.wait_not_present("div.pf-v5-c-modal-box")

return self

def expectDownloadErrorForNonExistingTag(self):
b.wait_not_present('div.pf-v5-c-modal-box')
title = f"Danger alert:Failed to download image localhost:5000/{self.imageName}:{self.imageTag}"
b.wait_visible(f'h4.pf-v5-c-alert__title:contains("{title}")')

return self

def expectSearchErrorForNotExistingImage(self):
b.wait_visible(f".pf-v5-c-modal-box__body:contains(No results for {self.imageName})")
b.click(".pf-v5-c-modal-box button.btn-cancel")
b.wait_not_present(".pf-v5-c-modal-box__body")

return self

Expand Down