Skip to content

Commit

Permalink
Makefile: Update Cockpit lib to c062fd73b3a7746446510012cfda5911
Browse files Browse the repository at this point in the history
Skip testCreatePod{User,System} on Firefox for now. The slightly
different timing greatly amplifies the state tracking bug to the point
where it's almost impossible to get this green. See #1836

Closes #1842
  • Loading branch information
cockpituous authored and mvollmer committed Sep 6, 2024
1 parent f020900 commit d0e0223
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ COCKPIT_REPO_FILES = \
$(NULL)

COCKPIT_REPO_URL = https://github.com/cockpit-project/cockpit.git
COCKPIT_REPO_COMMIT = e61c1de5b7a6069a1f4dec2ce871b2e912921878 # 322 + 42 commits
COCKPIT_REPO_COMMIT = c062fd73b3a7746446510012cfda5911694e31fd # 324 + 3 commits

$(COCKPIT_REPO_FILES): $(COCKPIT_REPO_STAMP)
COCKPIT_REPO_TREE = '$(strip $(COCKPIT_REPO_COMMIT))^{tree}'
Expand Down
4 changes: 4 additions & 0 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -2908,9 +2908,13 @@ class TestApplication(testlib.MachineCase):
b.wait_visible(container_1_sel + " .ct-badge-toolbox:contains('toolbox')")
b.wait_visible(container_2_sel + " .ct-badge-distrobox:contains('distrobox')")

# this isn't *really* a Firefox bug, but the different timing just triggers this a lot
# https://github.com/cockpit-project/cockpit-podman/issues/1836
@testlib.skipBrowser("pod dialog state management is broken", "firefox")
def testCreatePodSystem(self):
self._createPod(True)

@testlib.skipBrowser("pod dialog state management is broken", "firefox")
def testCreatePodUser(self):
self._createPod(False)

Expand Down

0 comments on commit d0e0223

Please sign in to comment.