Skip to content

Commit

Permalink
test: Drop stray Enter key presses from testRunImage
Browse files Browse the repository at this point in the history
These were introduced in commit a47c186 without justification,
and it's not clear what they were meant to do. Depending on the timing
they change/mess up the value in the file choosers, leading to random test
failures.
  • Loading branch information
martinpitt committed Aug 21, 2024
1 parent 688bac1 commit 769bcb1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -1952,10 +1952,8 @@ class TestApplication(testlib.MachineCase):
b.wait_not_present('#run-image-dialog-volume-0-selinux')

b.set_file_autocomplete_val("#run-image-dialog-volume-0 .pf-v5-c-select", rodir)
b.key("Enter")
b.set_input_text('#run-image-dialog-volume-0-container-path', '/tmp/ro')
ro_label = m.execute(f"ls -dZ {rodir}").split(" ")[0]
b.key("Enter")
b.click('.volume-form .btn-add')
b.wait_visible('#run-image-dialog-volume-1')
b.click('#run-image-dialog-volume-1-btn-close')
Expand All @@ -1973,7 +1971,6 @@ class TestApplication(testlib.MachineCase):
b.wait_not_present('#run-image-dialog-volume-2-selinux')

b.set_file_autocomplete_val("#run-image-dialog-volume-2 .pf-v5-c-select", rwdir)
b.key("Enter")
b.set_input_text('#run-image-dialog-volume-2-container-path', '/tmp/rw')
rw_label = m.execute(f"ls -dZ {rwdir}").split(" ")[0]

Expand Down

0 comments on commit 769bcb1

Please sign in to comment.