Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate :contains #665

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Eliminate :contains #665

merged 4 commits into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. test: Drop unnecessary wait_visible() call 

    The `do_deployment_action` already clicks that very "Roll back" button
that this line asserted. This just looks like a leftover from some test
refactoring.
    @martinpitt
    martinpitt committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0121751 View commit details
    Browse the repository at this point in the history

  2. test: Eliminate :contains selector in switch_tab() 

    Unfortunately this happens deep in the PatternFly component, inside of
cockpit-components-listing-table.jsx, so we can't easily add classes/IDs
to it. But it's always the same 3 tabs anyway, so use constants instead.
    @martinpitt
    martinpitt committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    56abfa8 View commit details
    Browse the repository at this point in the history

  3. test: Eliminate :contains selector in in do_deployment_action() 

    Give the kebab menu items a `data-action` attribute and select on this
instead.
    @martinpitt
    martinpitt committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a968ea9 View commit details
    Browse the repository at this point in the history

  4. test: Eliminate contains selector in do_deployment_action() 

    Similarly to the previous commit, add `data-action` attributes to the
card actions and select on them.
    @martinpitt
    martinpitt committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5644950 View commit details
    Browse the repository at this point in the history