test: add a test that creating VMs until no default name generated and checking #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunmingyang
force-pushed
the
testCreateVMs
branch
3 times, most recently
from
d7107c2
to
104b3cc
Compare
yunmingyang
force-pushed
the
testCreateVMs
branch
from
104b3cc
to
556d13c
Compare
jelly
reviewed
Sep 4, 2024
| @@ -304,6 +308,37 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase): | |||
| create_and_run=False), | |||
| check_env_empty=False) | |||
|
|
|||
| # Create VMs until no default generated name | |||
| for v in string.ascii_uppercase: | |||
There was a problem hiding this comment.
This seems very expensive, it seems to add 3 minutes to our total CI runtime.
There was a problem hiding this comment.
But these VMs are just defined, not started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.