Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patternfly: Give empty "Th" elements a aria-label attribute #1635

Merged
merged 1 commit into from
May 21, 2024
Merged

patternfly: Give empty "Th" elements a aria-label attribute #1635

merged 1 commit into from
May 21, 2024

Commits on May 14, 2024

  1. patternfly: Give empty "Th" elements a aria-label attribute 

    As requested by this warning:

    Th: Table headers must have an accessible name. If the Th is
    intended to be visually empty, pass in screenReaderText. If the Th
    contains only non-text, interactive content such as a checkbox or
    expand toggle, pass in an aria-label.

We can't use screenReaderText because of

    patternfly/patternfly#6643
    @mvollmer
    mvollmer committed May 14, 2024
    Configuration menu
    Copy the full SHA
    183813d View commit details
    Browse the repository at this point in the history