Remember VM state filter settings #1035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhoghoshX
force-pushed
the
remember-state
branch
3 times, most recently
from
f413594
to
30eb8fb
Compare
subhoghoshX
force-pushed
the
remember-state
branch
from
30eb8fb
to
274ffaa
Compare
|
Oops, tests failed because I used a semicolon in Python. fixed it :) |
KKoukiou
requested changes
Apr 21, 2023
subhoghoshX
force-pushed
the
remember-state
branch
3 times, most recently
from
4a572ec
to
9992f8c
Compare
subhoghoshX
force-pushed
the
remember-state
branch
from
9992f8c
to
8bc268c
Compare
KKoukiou
requested changes
May 17, 2023
There was a problem hiding this comment.
I believe it's a bit weird to keep the 'status' filter in the URL when we are out of the VM list page. So VM details, Storage and Network pages should not have the 'status=running' in the URL.
This is because:
- The status variable does not have any effect in these subpages
- It's slightly confusing as Storage and Networks have also active/inactive state, which would be confused with the status property in the URL.
So please make this persist only for the main page, and adjust the test accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032