Skip to content

Commit

Permalink
test: Restrict "invalid prop" warning to VolumeCreateBody.size
Browse files Browse the repository at this point in the history
This is non-trivial to fix, see issue #1273 for the details.
  • Loading branch information
martinpitt committed Oct 27, 2023
1 parent 29c8f29 commit 983fea3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/machineslib.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ def setUp(self):
"Tried changing state of a disconnected RFB object",
"Failed to get libvirt version from the dbus API:.*Cannot recv data: Connection reset by peer",
# FIXME: React errors on /devel scenario; these are actual bugs!
"Warning: Failed.*type.*Invalid prop",
"Warning: .* prop on .* should not be null.",
"Warning: Received .* for a non-boolean attribute",
'Warning: Each child in a list should have a unique "key" prop',
Expand All @@ -442,6 +441,8 @@ def setUp(self):
"Warning: A future version of React will block javascript: URLs as a security precaution.",
# FIXME:: https://github.com/cockpit-project/cockpit-machines/issues/1272
"Warning: Failed.*type:.*The prop `format` is marked as required in `VolumeCreateBody`, but its value is `undefined`",
# FIXME: https://github.com/cockpit-project/cockpit-machines/issues/1273
" Warning: Failed.*type:.* Invalid prop `size` of type `string` supplied to `VolumeCreateBody`, expected `number`",
)

def downloadVmXml(self, vm):
Expand Down

0 comments on commit 983fea3

Please sign in to comment.