Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 #825

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

Jelle van der Waa (2):
test: restore fstab/crypttab for RHEL 8 storage tests
lib: restrict SASS plugin to scss files

Marius Vollmer (10):
lib: Copy TypeaheadSelect into our code
lib: Fix TypeScript error in TypeaheadSelect
lib: Optionally trust selected property in TypeaheadSelect
lib: Support dividers with TypeaheadSelect
lib: Hide clear button in TypeaheadSelect when it would do nothing
lib: Simplify and translate UI texts in TypeaheadSelect
storage: Use TypeaheadSelect instead of deprecated Select
lib: Use TypeaheadSelect instead of deprecated Select for timezones
lib: Use TypeaheadSelect instead of deprecated Select for FileAutoComplete
lib: Fix TypeScript error in TypeaheadSelect correctly

Martin Pitt (4):
lib: Properly type getLastlog2
lib: Add typing for cockpit.jump() and cockpit.dbus().call()
lib: Initial typing of python.js
base1: Make TransportGlobals actually global

@github-actions github-actions bot added the bot label Nov 7, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 Makefile: Update Cockpit lib to c295842a0336c9e967a0c5adc28ddf52 Nov 7, 2024
@github-actions github-actions bot force-pushed the cockpit-lib-update-cockpit-lib-20241107-024402 branch from 9a6d9cd to da2827c Compare November 7, 2024 02:44
@martinpitt
Copy link
Member

martinpitt commented Nov 7, 2024

Hmm, how is that related to a lib update? 🤔 I'll take a look, @jelly has too many issues at hand already.

# /work/make-checkout-workdir/src/dialogs/permissions.jsx
#   34:1  error  There should be at least one empty line between import groups  import/order
#   35:1  error  There should be at least one empty line between import groups  import/order
#   35:1  error  `python.js` import should occur before import of `cockpit`     import/order

Update: Ah, it's due to the python.js → python.ts renaming.

@martinpitt martinpitt self-assigned this Nov 7, 2024
martinpitt and others added 2 commits November 7, 2024 06:45
Upcoming cockpit lib update renames `python.js` to `python.ts`. Drop the
explicit extension in the `import` statement, like we already do for the
other modules.
@martinpitt martinpitt force-pushed the cockpit-lib-update-cockpit-lib-20241107-024402 branch from da2827c to 1cc2335 Compare November 7, 2024 05:45
@martinpitt martinpitt requested a review from jelly November 7, 2024 06:05
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jelly jelly merged commit 7bd1472 into main Nov 7, 2024
26 checks passed
@jelly jelly deleted the cockpit-lib-update-cockpit-lib-20241107-024402 branch November 7, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants