Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: Move rhel-10-0 from beta to final #7095

Merged
merged 3 commits into from
Nov 16, 2024
Merged

images: Move rhel-10-0 from beta to final #7095

merged 3 commits into from
Nov 16, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Nov 13, 2024 •
edited
Loading

@martinpitt martinpitt added the bot label Nov 13, 2024
@cockpituous cockpituous changed the title images: Move rhel-10-0 from beta to final WIP: bb4280f62017: [no-test] images: Move rhel-10-0 from beta to final Nov 13, 2024
@martinpitt martinpitt mentioned this pull request Nov 13, 2024
Open
3 tasks
@cockpituous
Copy link
Contributor

image-refresh rhel-10-0 done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel-10-0-20241113-165626

@cockpituous cockpituous changed the title WIP: bb4280f62017: [no-test] images: Move rhel-10-0 from beta to final images: Move rhel-10-0 from beta to final Nov 13, 2024
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel-10-0-0520313e-20241113-164028/log.html

@martinpitt
Copy link
Member Author

This is quite a large jump, I expect the same pcp regressions / FIPS changes as in #7091. Let's see!

@martinpitt
Copy link
Member Author

Kernel oops with FIPS: https://issues.redhat.com/browse/RHEL-65498 (could require a naughty). Fortunately this doesn't yet break centos-10 (#7091), so testing my changes on that image instead.

@martinpitt martinpitt mentioned this pull request Nov 14, 2024
Merged
@martinpitt
Copy link
Member Author

FIPS fixed in cockpit-project/cockpit#21264 (blocking). Tests running there.

@martinpitt martinpitt added bot and removed bot labels Nov 14, 2024
@cockpituous cockpituous changed the title images: Move rhel-10-0 from beta to final WIP: 8bfc4b228e57: [no-test] images: Move rhel-10-0 from beta to final Nov 14, 2024
@cockpituous
Copy link
Contributor

image-refresh rhel-10-0 done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel-10-0-20241114-110909

@cockpituous cockpituous changed the title WIP: 8bfc4b228e57: [no-test] images: Move rhel-10-0 from beta to final images: Move rhel-10-0 from beta to final Nov 14, 2024
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel-10-0-e02a9c5b-20241114-105121/log.html

@martinpitt martinpitt marked this pull request as ready for review November 15, 2024 11:09
martinpitt and others added 3 commits November 15, 2024 12:09
@martinpitt
images: Move rhel-10-0 from beta to final
1d5df1a
@martinpitt
images: Install kernel with fixed FIPS on rhel-10-0
3ccb672 
Current nightly RHEL 10 images oops the kernel in FIPS mode
(https://issues.redhat.com/browse/RHEL-65498). This breaks Cockpit's
crypto-policies tests in a really awkward way that takes > 15 minutes to
eventually fail, and so handling this through a naughty is awkward.
Install the fixed kernel instead.

This automatically becomes a no-op as soon as the next kernel lands.
@martinpitt
images: Update rhel-10-0 image
582eaaf
jelly
jelly approved these changes Nov 15, 2024
View reviewed changes
images/scripts/rhel.setup
# takes ages, so too expensive/intrusive for a naughty to work around; install the proposed fix instead
if [ "$IMAGE" = "rhel-10-0" ] && [ "$(uname -r)" = "6.11.0-28.el10.x86_64" ]; then
dnf update -y https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-core-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-modules-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-modules-core-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-tools-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/kernel-tools-libs-6.11.0-29.3_1538040423.el10.x86_64.rpm https://artifacts.internal.cki-project.org/arr-cki-prod-internal-artifacts/internal-artifacts/1538040565/publish_x86_64/8332871928/artifacts/repo/6.11.0-29.3_1538040423.el10.x86_64/python3-perf-6.11.0-29.3_1538040423.el10.x86_64.rpm
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 feels appropriate here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look behind! A three-headed monkey! 🐵 🐵 🐵

@martinpitt
Copy link
Member Author

Meh, testAddDiskNFS puts up a good fight, that smells like more NFS fallout. Investigating..

mvollmer
mvollmer approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pretty, but "ok". :-)

@martinpitt
Copy link
Member Author

Fun, that test takes very long, due to some SELinux problem, and then unceremoniously reboots the VM without a further log entry. That smells an awful lot like cockpit-project/cockpit-machines#1900 ?

This command:

virsh vol-create-as --pool nfs-pool --name nfs-volume-0 --capacity 1M --format qcow2

also takes suspiciously long, like half a minute.

It passes with setenforce 0. Checking this more closely..

@martinpitt martinpitt mentioned this pull request Nov 15, 2024
Merged
@martinpitt
Copy link
Member Author

cockpit-project/cockpit-machines#1909 should help, WFM locally.

@martinpitt martinpitt self-assigned this Nov 15, 2024
@jelly
Copy link
Member

jelly commented Nov 16, 2024

Uhhh!

@jelly jelly reopened this Nov 16, 2024
@jelly
Copy link
Member

jelly commented Nov 16, 2024

I'd like machines to go green here do, so needs a retry.

@martinpitt martinpitt merged commit 938748e into cockpit-project:main Nov 16, 2024
20 checks passed
@martinpitt martinpitt deleted the r10-final branch November 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvollmer mvollmer mvollmer approved these changes

@jelly jelly jelly approved these changes

Assignees

@martinpitt martinpitt

Labels
blocked bot
Projects
Pilot tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpitt @cockpituous @jelly @mvollmer