Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Include the "clevis" package set in Fedora and RHEL images #3955

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Oct 11, 2022

The tests for fixing the system configuration for NBDE will want to install them.

  • image-refresh fedora-36

@mvollmer mvollmer added the bot label Oct 11, 2022
@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora images WIP: rhos-01-12: [no-test] images: Include the "clevis" package set in Fedora images Oct 11, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on rhos-01-12.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221011-090505/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: rhos-01-12: [no-test] images: Include the "clevis" package set in Fedora images images: Include the "clevis" package set in Fedora images Oct 11, 2022
@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora images WIP: 4-cockpit-9: [no-test] images: Include the "clevis" package set in Fedora images Oct 11, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on 4-cockpit-9.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221011-091919/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 4-cockpit-9: [no-test] images: Include the "clevis" package set in Fedora images images: Include the "clevis" package set in Fedora images Oct 11, 2022
@mvollmer
Copy link
Member Author

@mvollmer mvollmer marked this pull request as ready for review October 12, 2022 06:10
@mvollmer
Copy link
Member Author

I still have to sort out a lot of portability issues in cockpit-project/cockpit#17796 so, hmm, not sure how to proceed here. We could wait until the feature work actually blocks on this.

@mvollmer
Copy link
Member Author

And we want this for RHEL as well, at least... So I guess let's keep this draft after all.

@mvollmer mvollmer marked this pull request as draft October 12, 2022 06:19
@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora images WIP: 1-ci-srv-01: [no-test] images: Include the "clevis" package set in Fedora images Oct 14, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on 1-ci-srv-01.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221014-112020/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 1-ci-srv-01: [no-test] images: Include the "clevis" package set in Fedora images images: Include the "clevis" package set in Fedora images Oct 14, 2022
@mvollmer mvollmer force-pushed the image-package-sets branch 2 times, most recently from 5e7c64a to 2224b62 Compare October 14, 2022 13:14
@mvollmer mvollmer changed the title images: Include the "clevis" package set in Fedora images images: Include the "clevis" package set in Fedora and RHEL images Oct 14, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on rhos-01-14.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221014-131515/

@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora and RHEL images WIP: rhos-01-14: [no-test] images: Include the "clevis" package set in Fedora and RHEL images Oct 14, 2022
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: rhos-01-14: [no-test] images: Include the "clevis" package set in Fedora and RHEL images images: Include the "clevis" package set in Fedora and RHEL images Oct 14, 2022
@mvollmer mvollmer marked this pull request as ready for review October 17, 2022 12:34
@mvollmer mvollmer requested a review from marusak October 17, 2022 12:39
@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora and RHEL images WIP: 4-ci-srv-04: [no-test] images: Include the "clevis" package set in Fedora and RHEL images Oct 17, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on 4-ci-srv-04.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221017-125656/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 4-ci-srv-04: [no-test] images: Include the "clevis" package set in Fedora and RHEL images images: Include the "clevis" package set in Fedora and RHEL images Oct 17, 2022
@cockpituous cockpituous changed the title images: Include the "clevis" package set in Fedora and RHEL images WIP: rhos-01-10: [no-test] images: Include the "clevis" package set in Fedora and RHEL images Oct 17, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on rhos-01-10.
Log: https://logs.cockpit-project.org/logs/image-refresh-3955-20221017-130606/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: rhos-01-10: [no-test] images: Include the "clevis" package set in Fedora and RHEL images images: Include the "clevis" package set in Fedora and RHEL images Oct 17, 2022
mvollmer and others added 2 commits October 17, 2022 16:31
The tests for fixing the system configuration for NBDE will want to
install them.
@mvollmer
Copy link
Member Author

The pixel failures in TestStorageUsed.testUsed are persistent. I have a look.

@mvollmer
Copy link
Member Author

The pixel failures in TestStorageUsed.testUsed are persistent. I have a look.

It's bash doing tail-call optimization, apparently. Instead of forking for "sleep infinity", it just execs the sleep into its own process. Bash did indeed get updated during the image refresh.

@mvollmer
Copy link
Member Author

The pixel failures in TestStorageUsed.testUsed are persistent. I have a look.

It's bash doing tail-call optimization, apparently. Instead of forking for "sleep infinity", it just execs the sleep into its own process. Bash did indeed get updated during the image refresh.

cockpit-project/cockpit#17823

Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marusak marusak merged commit 06147a3 into cockpit-project:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants