Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add towncrier #53

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Docs: Add towncrier #53

merged 1 commit into from
Jan 23, 2023

Conversation

tiltingpenguin
Copy link
Collaborator

Part of #48

Successful implementation can be found at cobbler/koan#93

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tiltingpenguin tiltingpenguin added the documentation Improvements or additions to documentation label Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 53.36% // Head: 53.36% // No change to project coverage 👍

Coverage data is based on head (d7a6fe3) compared to base (ef9620f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   53.36%   53.36%           
=======================================
  Files           6        6           
  Lines         757      757           
=======================================
  Hits          404      404           
  Misses        353      353           
Flag Coverage Δ
unittests 53.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit e46f7f2 into main Jan 23, 2023
@SchoolGuy SchoolGuy deleted the feature/add-towncrier branch January 23, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants