Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Item overview and read only detail pages #269

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Jul 20, 2024

Fixes #65

This PR is currently a WIP!

Open points:

  • Enable Cobbler-API tests for all item types
  • Add detail view for all item types

I think the scope of this PR is making the edit functionality work, but it should be taken care of that this is implemented as a no-op already.

Due to two missing UI components (#270, #271), it is also out of scope to display list and dict type attributes.

Edit: I noticed that we also don't have a shared component yet to display if a value is inherited or not. As such this is also out of scope (see #279). This PR should just show the values with their correct datatype if the type is scalar.

Screenshots:

Overview:

Screenshot 2024-07-20 at 18-27-08 Cobbler

Details:

Screenshot 2024-07-20 at 18-27-00 Cobbler

List and Dict View:

grafik

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Jul 20, 2024
@github-actions github-actions bot added API-Client Project cobbler-client Frontend Project cobbler-frontend labels Jul 20, 2024
@SchoolGuy SchoolGuy force-pushed the feature/add-item-overview branch from 3abe8b2 to 6afb794 Compare July 20, 2024 19:49
@SchoolGuy SchoolGuy marked this pull request as ready for review July 31, 2024 16:55
@SchoolGuy SchoolGuy requested a review from 00Kadie00 July 31, 2024 16:55
@SchoolGuy SchoolGuy force-pushed the feature/add-item-overview branch from b4deab4 to 86b5aee Compare July 31, 2024 17:01
@SchoolGuy SchoolGuy merged commit a0e2029 into main Aug 12, 2024
14 of 15 checks passed
@SchoolGuy SchoolGuy deleted the feature/add-item-overview branch August 12, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Client Project cobbler-client Frontend Project cobbler-frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Table with configurable overview for Items
2 participants