package.json: Set license to GPLv3 #43
Conversation
|
Commit message is "GPLV3" which isn't what the commit does. |
bekicot
changed the title
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "private": true, | |||
| "description": "Small description for gsoc-prep-tasks goes here", | |||
| "license": "MIT", | |||
| "license": "GPLv3", | |||
There was a problem hiding this comment.
https://docs.npmjs.com/files/package.json#license says to use an identifier on https://spdx.org/licenses/
GPLv3 isnt on that list.
bekicot
force-pushed
the
update-license
branch
2 times, most recently
from
3f905f2 to
cacaeb8
Compare
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "private": true, | |||
| "description": "Small description for gsoc-prep-tasks goes here", | |||
| "license": "MIT", | |||
| "license": "GPL-3.0-only", | |||
There was a problem hiding this comment.
LICENSE.md said either version 3 of the License, or (at your option) any later version.
Should be or-later, see header of https://spdx.org/licenses/GPL-3.0-or-later.html#licenseText
Although, GPL-3.0-only also said either version https://spdx.org/licenses/GPL-3.0-only.html#licenseText ,
the header is different.
There was a problem hiding this comment.
Good eyes ... spdx/license-list-XML#610 and spdx/license-list-XML#617 are about this problem.
There was a problem hiding this comment.
We can ignore that bit, but it will be relevant to any attempt at automating the LICENSE files via moban :/
The important part is that the GPL-3.0-only requires the preamble which says ', version 3.' and this repo LICENSE doesnt have that.
See placement of <standardLicenseHeader> in
https://github.com/spdx/license-list-XML/blob/master/src/GPL-3.0-only.xml
whereas <standardLicenseHeader> is in <optional> in
https://github.com/spdx/license-list-XML/blob/master/src/GPL-3.0-or-later.xml
|
ack 215892c |
Fixes #41