MarkdownBear: verify config_file #981

Nosferatul · 2016-11-07T11:29:08Z

If the config_file is provided, all other options are ignored.

Closes #925

gitmate-bot · 2016-11-07T11:29:20Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2016-11-07T11:29:34Z

Comment on 8dd427a.

Shortlog of HEAD commit does not match given regex.

GitCommitBear, severity NORMAL, section commit.

sils · 2016-11-07T13:01:44Z

bears/markdown/MarkdownBear.py

-        config_json = json.dumps(remark_configs)
-        # Remove { and } as remark adds them on its own
-        settings = config_json[1:-1]
-        return '--no-color', '--quiet', '--setting', settings


wait - did this actually work? At least this commit seems to be not helpful, config_file should be None all the time

I don't understand the purpose of the issue if the config_file should be None all the time.

you have to override https://github.com/coala/coala/blob/master/coalib/bearlib/abstractions/Linter.py#L127 for the config to be generated, then config_file will hold a filename of that config

I'm fairly confused by this. Where does config_file get set? Where does the value come from?

sils · 2016-11-07T13:05:37Z

770cb24 will introduce definite bugs, needs work

gitmate-bot · 2016-11-14T13:34:14Z

bears/markdown/MarkdownBear.py

+
+@staticmethod
+def generate_config(filename, file):
+    return filename


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -14,6 +14,7 @@ @staticmethod def generate_config(filename, file): return filename + class MarkdownBear: """

gitmate-bot · 2016-11-14T13:34:14Z

bears/markdown/MarkdownBear.py

 from coalib.bears.requirements.NpmRequirement import NpmRequirement


 @linter(executable='remark',
        use_stdin=True,
        output_format='corrected',
        result_message='The text does not comply to the set style.')
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -10,7 +10,6 @@ use_stdin=True, output_format='corrected', result_message='The text does not comply to the set style.') - @staticmethod def generate_config(filename, file): return filename

gitmate-bot · 2016-11-14T13:34:15Z

bears/markdown/MarkdownBear.py

@@ -1,13 +1,20 @@
 import json

 from coalib.bearlib.abstractions.Linter import linter
+from coalib.bearlib.abstractions.Linter import
+                                    _create_linter.LinterBase.generate_config


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -2,7 +2,7 @@ from coalib.bearlib.abstractions.Linter import linter from coalib.bearlib.abstractions.Linter import - _create_linter.LinterBase.generate_config + _create_linter.LinterBase.generate_config from coalib.bears.requirements.NpmRequirement import NpmRequirement

gitmate-bot · 2016-11-14T13:36:18Z

bears/markdown/MarkdownBear.py

 from coalib.bears.requirements.NpmRequirement import NpmRequirement


 @linter(executable='remark',
        use_stdin=True,
        output_format='corrected',
        result_message='The text does not comply to the set style.')
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -10,7 +10,6 @@ use_stdin=True, output_format='corrected', result_message='The text does not comply to the set style.') - @staticmethod def generate_config(filename, file): return filename

gitmate-bot · 2016-11-14T13:36:18Z

bears/markdown/MarkdownBear.py

@@ -1,13 +1,21 @@
 import json

 from coalib.bearlib.abstractions.Linter import linter
+from coalib.bearlib.abstractions.Linter import
+                                    _create_linter.LinterBase.generate_config


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -2,7 +2,7 @@ from coalib.bearlib.abstractions.Linter import linter from coalib.bearlib.abstractions.Linter import - _create_linter.LinterBase.generate_config + _create_linter.LinterBase.generate_config from coalib.bears.requirements.NpmRequirement import NpmRequirement

gitmate-bot · 2016-11-14T13:38:11Z

bears/markdown/MarkdownBear.py

@@ -1,13 +1,20 @@
 import json

 from coalib.bearlib.abstractions.Linter import linter
+from coalib.bearlib.abstractions.Linter import
+                                    _create_linter.LinterBase.generate_config


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/markdown/MarkdownBear.py +++ b/bears/markdown/MarkdownBear.py @@ -2,7 +2,7 @@ from coalib.bearlib.abstractions.Linter import linter from coalib.bearlib.abstractions.Linter import - _create_linter.LinterBase.generate_config + _create_linter.LinterBase.generate_config from coalib.bears.requirements.NpmRequirement import NpmRequirement

gitmate-bot · 2016-11-14T14:13:01Z

bears/markdown/MarkdownBear.py

@@ -1,13 +1,18 @@
 import json

-from coalib.bearlib.abstractions.Linter import linter
+from coalib.bearlib.abstractions.Linter import linter, _create_linter.LinterBase


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2017-01-06T12:38:48Z