JavaPMDBear: Use dependency_management #1667

Techievena · 2017-04-25T13:36:18Z

Fetch pmd and bash using MavenRequirement and DistributionRequirement
respectively

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Fetch pmd and bash using MavenRequirement and DistributionRequirement respectively Closes coala#1662

jayvdb · 2017-04-25T13:44:32Z

bears/java/JavaPMDBear.py

@@ -17,22 +17,14 @@ class JavaPMDBear:
    """

    LANGUAGES = {'Java'}
+    REQUIREMENTS = {MavenRequirement('net.sourceforge.pmd:pmd', '5.6.0'),


this would be a breaking change.
MavenRequirement needs to be an optional way to obtain pmd.

And I am pretty sure that the maven pmd doesnt install a pmd executable.

i.e. you need to test that old and new work, which is why this is listed as medium difficulty

Sorry my bad just overlooked this and thought it would merely be adding the requirement line. Will fix this shortly.

You forgot to import MavenRequirement.

adhikasp · 2017-04-25T13:45:51Z

bears/java/JavaPMDBear.py

@@ -17,22 +17,14 @@ class JavaPMDBear:
    """

    LANGUAGES = {'Java'}
+    REQUIREMENTS = {MavenRequirement('net.sourceforge.pmd:pmd', '5.6.0'),


Our CI test is using v 5.4.1 https://github.com/coala/coala-bears/blob/master/.ci/deps.sh#L163

But if you already check that it's not breaking then OK (and maybe we need to update the CI script)

Thanks for the suggestion @adhikasp will surely fix this. But a lot of work needs to be done first. 😃

Techievena · 2017-05-02T17:57:16Z

@jayvdb This is what I think should be for the maven bears

Create an empty maven project if not present
Copy the file to be analyzed to the src directory of the project
Modify the pom.xml file to add the requisite plugins and rulesets according to user inputs
Fetch dependencies using MavenRequirement
Build the project
Wrap the results of the build to generate results for the bear

Please correct me. 😃

gitmate-bot · 2017-05-09T22:23:34Z