InferBear: Add support for other languages

Closes #541
coala · Nov 19, 2016 · a9636b6 · a9636b6
1 parent ce29fcc
commit a9636b6
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 10 deletions.
diff --git a/bears/java/InferBear.py b/bears/java/InferBear.py
@@ -9,13 +9,24 @@ class InferBear:
     """
     Checks the code with ``infer``.
     """
-    LANGUAGES = {"Java"}
+    LANGUAGES = {"Java", "Objective-C", "C"}
     AUTHORS = {'The coala developers'}
     AUTHORS_EMAILS = {'[email protected]'}
     LICENSE = 'AGPL-3.0'
     ASCIINEMA_URL = 'https://asciinema.org/a/1g2k0la7xo5az9t8f1v5zy66q'
     CAN_DETECT = {'Security'}
 
-    @staticmethod
-    def create_arguments(filename, file, config_file):
-        return '-npb', '--', 'javac', filename
+    def create_arguments(self, filename, file, config_file, language: str):
+        """
+        :param language: The language to analyze (Java, Objective-C or C).
+        """
+        language_args = {
+            'java': ('javac',),
+            'objective-c': ('clang', '-c'),
+            'c': ('gcc', '-c')
+        }
+        if language not in language_args:
+            self.err("Invalid language given! Falling back to Java.")
+            language = 'java'
+
+        return ('-npb', '--') + language_args[language.lower()] + (filename,)
diff --git a/tests/java/InferBearTest.py b/tests/java/InferBearTest.py
@@ -2,7 +2,9 @@
 from tests.LocalBearTestHelper import verify_local_bear
 
 
-good_file = """
+# All examples taken from http://fbinfer.com/docs/hello-world.html
+
+good_java_file = """
 class InferGood {
     int test() {
         String s = null;
@@ -11,7 +13,7 @@ class InferGood {
 }
 """
 
-bad_file = """
+bad_java_file = """
 class InferBad {
     int test() {
         String s = null;
@@ -20,8 +22,38 @@ class InferBad {
 }
 """
 
+good_c_file = """
+#include <stdlib.h>
+
+void test() {
+  int *s = NULL;
+  if (s != NULL) {
+    *s = 42;
+  }
+}
+"""
+
+bad_c_file = """
+#include <stdlib.h>
+
+void test() {
+  int *s = NULL;
+  *s = 42;
+}
+"""
+
+
+InferBearJavaTest = verify_local_bear(
+    InferBear, valid_files=(good_java_file,), invalid_files=(bad_java_file,),
+    tempfile_kwargs={"suffix": ".java"}, settings={'language': 'JAVA'})
+
+
+# InferBear falls back to java if no valid language is given
+InferBearFallbackLanguageTest = verify_local_bear(
+    InferBear, valid_files=(good_java_file,), invalid_files=(bad_java_file,),
+    tempfile_kwargs={"suffix": ".java"}, settings={'language': 'bullshit'})
+
 
-InferBearTest = verify_local_bear(InferBear,
-                                  valid_files=(good_file,),
-                                  invalid_files=(bad_file,),
-                                  tempfile_kwargs={"suffix": ".java"})
+InferBearCTest = verify_local_bear(
+    InferBear, valid_files=(good_c_file,), invalid_files=(bad_c_file,),
+    tempfile_kwargs={"suffix": ".c"}, settings={'language': 'objective-c'})