-
Notifications
You must be signed in to change notification settings - Fork 581
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce PHPStanBear Checks the code with ``phpstan analyze``. Closes #1426
- Loading branch information
1 parent
8575b3f
commit 084b600
Showing
2 changed files
with
60 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import os | ||
|
||
from coalib.bearlib.abstractions.Linter import linter | ||
|
||
|
||
@linter(executable='phpstan', | ||
output_format='regex', | ||
output_regex=r'(?P<line>\d+) (?P<message>.*)') | ||
class PHPStanBear: | ||
""" | ||
Checks the code with ``phpstan analyze``. | ||
This can run it on multiple files and folders. | ||
See <https://github.com/phpstan/phpstan> for more information. | ||
""" | ||
LANGUAGES = {'PHP'} | ||
AUTHORS = {'The coala developers'} | ||
AUTHORS_EMAILS = {'[email protected]'} | ||
LICENSE = 'AGPL-3.0' | ||
CAN_DETECT = {'Syntax', 'Unused Code', 'Variable Misuse', | ||
'Undefined Element', 'Missing Import', 'Spelling'} | ||
|
||
@staticmethod | ||
def create_arguments(filename, file, config_file, phpstan_level: str='0', phpstan_config: str=''): | ||
""" | ||
:param phpstan_config: | ||
path to a custom configuration file. | ||
When using a custom project config file, you have to pass the phpstan_level argument | ||
(default value 0 does not apply here). | ||
:param phpstan_level: | ||
To set rule levels. | ||
0 is the loosest and 4 is the strictest. | ||
See <https://github.com/phpstan/phpstan> for more information. | ||
""" | ||
args = ('analyse', '--level='+phpstan_level, filename) | ||
if phpstan_config: | ||
args += ('-c '+phpstan_config,) | ||
return args |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
from bears.php.PHPStanBear import PHPStanBear | ||
from coalib.testing.LocalBearTestHelper import verify_local_bear | ||
|
||
|
||
good_file = """ | ||
<?php | ||
$a = 1; | ||
?> | ||
""" | ||
|
||
|
||
bad_file = """ | ||
<?php | ||
$a = | ||
?> | ||
""" | ||
|
||
|
||
PHPStanBearTest = verify_local_bear( | ||
PHPStanBear, | ||
valid_files=(good_file,), | ||
invalid_files=(bad_file,), | ||
tempfile_kwargs={'suffix': '.php'}) |