fix: Fix linter issues

pkg/apis/cce.pandaria.io/v1/types.go

@@ -166,7 +166,7 @@ type CCEClusterPublicIP struct {
 }
 
 type CCENodePublicIP struct {
-	Ids   []string `json:"ids,omitempty"`   // 已有的弹性IP的ID列表。数量不得大于待创建节点数
+	IDs   []string `json:"ids,omitempty"`   // 已有的弹性IP的ID列表。数量不得大于待创建节点数
 	Count int32    `json:"count,omitempty"` // 要动态创建的弹性IP个数。
 	Eip   CCEEip   `json:"eip,omitempty"`   // 弹性IP参数。
 }
@@ -187,7 +187,7 @@ type CCEClusterExtendParam struct {
 }
 
 type CCEClusterEndpoints struct {
-	Url  string `json:"url,omitempty"`
+	URL  string `json:"url,omitempty"`
 	Type string `json:"type,omitempty"`
 }
 

pkg/codegen/main.go

@@ -80,7 +80,7 @@ func newCRD(obj interface{}, customize func(crd.CRD) crd.CRD) crd.CRD {
 
 func saveCRDYaml(name, data string) error {
 	filename := fmt.Sprintf("./charts/%s/templates/crds.yaml", name)
-	if err := os.WriteFile(filename, []byte(data), 0644); err != nil {
+	if err := os.WriteFile(filename, []byte(data), 0600); err != nil {
 		return err
 	}
 

pkg/controller/cce-cluster-config-handler.go

@@ -298,7 +298,7 @@ func (h *Handler) generateAndSetNetworking(config *ccev1.CCEClusterConfig) (*cce
 		if dnsServers.Nameservers == nil || len(*dnsServers.Nameservers) == 0 {
 			return config, fmt.Errorf("ListNameServers returns invalid data")
 		}
-		var dnsRecords []string = make([]string, 2)
+		var dnsRecords = make([]string, 2)
 		for _, nameserver := range *dnsServers.Nameservers {
 			if nameserver.NsRecords == nil || len(*nameserver.NsRecords) == 0 {
 				continue
@@ -387,7 +387,7 @@ func (h *Handler) generateAndSetNetworking(config *ccev1.CCEClusterConfig) (*cce
 		if dnsServers.Nameservers == nil || len(*dnsServers.Nameservers) == 0 {
 			return config, fmt.Errorf("ListNameServers returns invalid data")
 		}
-		var dnsRecords []string = make([]string, 2)
+		var dnsRecords = make([]string, 2)
 		for _, nameserver := range *dnsServers.Nameservers {
 			if nameserver.NsRecords == nil || len(*nameserver.NsRecords) == 0 {
 				continue
@@ -661,9 +661,8 @@ func (h *Handler) checkAndUpdate(config *ccev1.CCEClusterConfig) (*ccev1.CCEClus
 				config = config.DeepCopy()
 				config.Status.UpgradeClusterTaskID = ""
 				return h.cceCC.UpdateStatus(config)
-			} else {
-				return config, err
 			}
+			return config, err
 		}
 		if res != nil && res.Spec != nil && res.Status != nil {
 			switch utils.Value(res.Status.Phase) {
@@ -722,7 +721,7 @@ func (h *Handler) checkAndUpdate(config *ccev1.CCEClusterConfig) (*ccev1.CCEClus
 		if len(configUpdate.Status.Endpoints) == len(*cluster.Status.Endpoints) {
 			for i := range *cluster.Status.Endpoints {
 				if configUpdate.Status.Endpoints[i].Type != utils.Value((*cluster.Status.Endpoints)[i].Type) ||
-					configUpdate.Status.Endpoints[i].Url != utils.Value((*cluster.Status.Endpoints)[i].Url) {
+					configUpdate.Status.Endpoints[i].URL != utils.Value((*cluster.Status.Endpoints)[i].Url) {
 					updateEndpoints = true
 				}
 			}
@@ -734,7 +733,7 @@ func (h *Handler) checkAndUpdate(config *ccev1.CCEClusterConfig) (*ccev1.CCEClus
 		configUpdate.Status.Endpoints = nil
 		for _, e := range *cluster.Status.Endpoints {
 			configUpdate.Status.Endpoints = append(configUpdate.Status.Endpoints, ccev1.CCEClusterEndpoints{
-				Url:  utils.Value(e.Url),
+				URL:  utils.Value(e.Url),
 				Type: utils.Value(e.Type),
 			})
 		}

pkg/controller/driver.go

@@ -58,7 +58,7 @@ func NewHuaweiDriver(auth *common.ClientAuth) *HuaweiDriver {
 		VPC:   vpc.NewVpcClient(auth),
 		EIP:   eip.NewEipClient(auth),
 		VPCEP: vpcep.NewVpcepClient(auth),
-		DNS:   dns.NewDnsClient(auth),
+		DNS:   dns.NewDNSClient(auth),
 		NAT:   nat.NewNatClient(auth),
 	}
 }

pkg/controller/upstream.go

@@ -107,7 +107,7 @@ func BuildUpstreamNodePoolConfigs(
 	if nodePools == nil || nodePools.Items == nil {
 		return nil, fmt.Errorf("BuildUpstreamNodePoolConfigs: invalid nil parameter")
 	}
-	var nps []ccev1.CCENodePool = make([]ccev1.CCENodePool, 0, len(*nodePools.Items))
+	var nps = make([]ccev1.CCENodePool, 0, len(*nodePools.Items))
 	if len(*nodePools.Items) == 0 {
 		return nps, nil
 	}
@@ -158,7 +158,7 @@ func BuildUpstreamNodePoolConfigs(
 			}
 		}
 		if np.Spec.NodeTemplate.PublicIP != nil {
-			config.NodeTemplate.PublicIP.Ids = utils.Value(np.Spec.NodeTemplate.PublicIP.Ids)
+			config.NodeTemplate.PublicIP.IDs = utils.Value(np.Spec.NodeTemplate.PublicIP.Ids)
 			config.NodeTemplate.PublicIP.Count = utils.Value(np.Spec.NodeTemplate.Count)
 			if np.Spec.NodeTemplate.PublicIP.Eip != nil {
 				config.NodeTemplate.PublicIP.Eip.Iptype = np.Spec.NodeTemplate.PublicIP.Eip.Iptype

pkg/controller/validate.go

@@ -22,9 +22,8 @@ func validateNodePool(config *ccev1.CCEClusterConfig) error {
 		}
 		if nodePoolNames[pool.Name] {
 			return fmt.Errorf("nodePool.name should be unique, duplicated detected: %q", pool.Name)
-		} else {
-			nodePoolNames[pool.Name] = true
 		}
+		nodePoolNames[pool.Name] = true
 		nt := pool.NodeTemplate
 		if nt.Flavor == "" {
 			return fmt.Errorf(cannotBeEmptyError, "nodePool.nodeTemplate.flavor", config.Name)

pkg/huawei/cce/cce.go

@@ -93,7 +93,7 @@ func GetCreateClusterRequest(config *ccev1.CCEClusterConfig) *model.CreateCluste
 		kubeProxyMode = model.GetClusterSpecKubeProxyModeEnum().IPTABLES
 	}
 
-	var clusterTags []model.ResourceTag
+	var clusterTags = make([]model.ResourceTag, 0)
 	for k, v := range spec.Tags {
 		clusterTags = append(clusterTags, model.ResourceTag{
 			Key:   utils.Pointer(k),

pkg/huawei/cce/node.go

@@ -208,8 +208,8 @@ func GetCreateNodePoolRequest(
 		)
 	}
 
-	if len(np.NodeTemplate.PublicIP.Ids) > 0 {
-		nodePoolBody.Spec.NodeTemplate.PublicIP.Ids = &np.NodeTemplate.PublicIP.Ids
+	if len(np.NodeTemplate.PublicIP.IDs) > 0 {
+		nodePoolBody.Spec.NodeTemplate.PublicIP.Ids = &np.NodeTemplate.PublicIP.IDs
 	}
 	chargeMode := "traffic"
 	if np.NodeTemplate.PublicIP.Eip.Bandwidth.ChargeMode != "traffic" {

pkg/huawei/dns/dns.go

@@ -8,7 +8,7 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-func NewDnsClient(c *common.ClientAuth) *dns.DnsClient {
+func NewDNSClient(c *common.ClientAuth) *dns.DnsClient {
 	return dns.NewDnsClient(
 		dns.DnsClientBuilder().
 			WithRegion(region.ValueOf(c.Region)).

pkg/huawei/huawei.go

@@ -5,39 +5,39 @@ import (
 	"encoding/json"
 )
 
-type HuaweiError struct {
+type Error struct {
 	StatusCode   int32  `json:"status_code,omitempty"`
 	RequestID    string `json:"request_id,omitempty"`
 	ErrorCode    string `json:"error_code,omitempty"`
 	ErrorMessage string `json:"error_message,omitempty"`
 }
 
-func NewHuaweiError(err error) (*HuaweiError, error) {
+func NewHuaweiError(err error) (*Error, error) {
 	var errMsg string
 	if err != nil {
 		errMsg = err.Error()
 	}
 	d := json.NewDecoder(bytes.NewBufferString(errMsg))
-	huaweiError := &HuaweiError{}
+	huaweiError := &Error{}
 	err = d.Decode(huaweiError)
 	return huaweiError, err
 }
 
 func IsHuaweiError(err error) bool {
 	d := json.NewDecoder(bytes.NewBufferString(err.Error()))
-	h := &HuaweiError{}
+	h := &Error{}
 	if err := d.Decode(h); err != nil {
 		return false
 	}
 	return true
 }
 
-func (e *HuaweiError) String() string {
+func (e *Error) String() string {
 	d, _ := json.Marshal(e)
 	return string(d)
 }
 
-func (e *HuaweiError) MarshalIndent() string {
+func (e *Error) MarshalIndent() string {
 	d, _ := json.MarshalIndent(e, "", "  ")
 	return string(d)
 }

pkg/utils/utils.go

@@ -1,10 +1,10 @@
 package utils
 
 import (
+	"crypto/rand"
 	"encoding/json"
-	"math/rand"
+	"math/big"
 	"strings"
-	"time"
 )
 
 func PrintObject(a any) string {
@@ -22,11 +22,15 @@ func Parse(ref string) (namespace string, name string) {
 
 // Generates a random hexadecimal number.
 func RandomHex(l int) string {
-	r := rand.New(rand.NewSource(time.Now().UnixNano()))
 	chars := []byte("abcdef0123456789")
+	big := new(big.Int).SetInt64(int64(len(chars)))
 	var b strings.Builder
 	for i := 0; i < l; i++ {
-		b.WriteByte(chars[r.Intn(len(chars))])
+		i, err := rand.Int(rand.Reader, big)
+		if err != nil {
+			return ""
+		}
+		b.WriteByte(chars[i.Int64()])
 	}
 
 	return b.String()