Skip to content

Commit

Permalink
chore(delete): remove ie driver and appium (#117)
Browse files Browse the repository at this point in the history
internet explorer has been deprecated for a while. Supporting appium is
out of scope for this project. We might revisit this later.
  • Loading branch information
cnishina committed Dec 16, 2023
1 parent a343962 commit 9feebe2
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 453 deletions.
2 changes: 1 addition & 1 deletion lib/cmds/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface Options {
}

export type BrowserDriverName =
'chromedriver'|'geckodriver'|'iedriver'|'chromium';
'chromedriver'|'geckodriver'|'chromium';

/**
* Contains information about a browser driver.
Expand Down
10 changes: 0 additions & 10 deletions lib/cmds/update.spec-int.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import * as rimraf from 'rimraf';

import {ChromeDriver} from '../provider/chromedriver';
import {GeckoDriver} from '../provider/geckodriver';
import {IEDriver} from '../provider/iedriver';
import {SeleniumServer} from '../provider/selenium_server';
import {OptionsBinary} from './options_binary';
import {updateBinary} from './update';
Expand Down Expand Up @@ -69,15 +68,6 @@ describe('update cmd', () => {
expect(fs.readdirSync(tmpDir).length).toBe(3);
});

it('should download iedriver files', async () => {
const iedriver = new IEDriver({outDir: tmpDir});
iedriver.osType = 'Windows_NT';
const optionsBinary:
OptionsBinary = {outDir: tmpDir, browserDrivers: [{binary: iedriver}]};
await updateBinary(optionsBinary);
expect(fs.readdirSync(tmpDir).length).toBe(4);
});

it('should download default files', async () => {
const optionsBinary: OptionsBinary = {
outDir: tmpDir,
Expand Down
7 changes: 0 additions & 7 deletions lib/cmds/utils.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as yargs from 'yargs';
import {ChromeDriver} from '../provider/chromedriver';
import {GeckoDriver} from '../provider/geckodriver';
import {IEDriver} from '../provider/iedriver';
import {ProviderConfig} from '../provider/provider';
import {SeleniumServer, SeleniumServerProviderConfig} from '../provider/selenium_server';

Expand Down Expand Up @@ -34,8 +33,6 @@ export function addOptionsBinary(options: Options): OptionsBinary {
const geckoProviderConfig = providerConfig;
geckoProviderConfig.oauthToken = optionsBinary.githubToken;
browserDriver.binary = new GeckoDriver(geckoProviderConfig);
} else if (browserDriver.name === 'iedriver') {
browserDriver.binary = new IEDriver(providerConfig);
}
}
}
Expand All @@ -62,7 +59,6 @@ export function convertArgs2AllOptions(argv: yargs.Arguments): Options {
{name: 'chromedriver'},
{name: 'chromium'},
{name: 'geckodriver'},
{name: 'iedriver'}
],
server: {name: 'selenium'},
outDir: argv['out_dir'] as string
Expand Down Expand Up @@ -93,9 +89,6 @@ export function convertArgs2Options(argv: yargs.Arguments): Options {
if (argv['geckodriver'] as boolean) {
setVersions('geckodriver', argv, options.browserDrivers);
}
if (argv['iedriver'] as boolean) {
setVersions('iedriver', argv, options.browserDrivers);
}
if (argv['selenium']) {
options.server = {};
options.server.name = 'selenium';
Expand Down
1 change: 0 additions & 1 deletion lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ export {update} from './cmds/update';
export {ChromeDriver} from './provider/chromedriver';
export {Chromium} from './provider/chromium';
export {GeckoDriver} from './provider/geckodriver';
export {IEDriver} from './provider/iedriver';
export {ProviderConfig, ProviderInterface} from './provider/provider';
export {SeleniumServer} from './provider/selenium_server';
80 changes: 0 additions & 80 deletions lib/provider/appium.spec-int.ts

This file was deleted.

68 changes: 0 additions & 68 deletions lib/provider/appium.ts

This file was deleted.

59 changes: 0 additions & 59 deletions lib/provider/iedriver.spec-int.ts

This file was deleted.

23 changes: 0 additions & 23 deletions lib/provider/iedriver.spec-unit.ts

This file was deleted.

Loading

0 comments on commit 9feebe2

Please sign in to comment.