Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cel: Add canonical CEL (dev.cel.expr) fields #89

Merged
merged 3 commits into from
Mar 29, 2024
Merged

cel: Add canonical CEL (dev.cel.expr) fields #89

merged 3 commits into from
Mar 29, 2024

Commits on Mar 28, 2024

  1. cel: Add canonical CEL (dev.cel.expr) fields 

    This PR adds canonical CEL
(https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields
to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created
identical to the `google.api.expr.v1alpha1`, but may be extended in a
backward-compatible way.

Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are
added outside of `oneof expr_specifier` per updated policy change:
envoyproxy/envoy#30851 2. `option
(validate.required) = true` is removed from the `oneof expr_specifier`,
so the users may not presume one of the `parsed_expr`, `checked_expr`
will be set.

Signed-off-by: Sergii Tkachenko <[email protected]>
    @sergiitk
    sergiitk committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    20565ea View commit details
    Browse the repository at this point in the history

  2. Generate go protobuf for xds/type/v3/cel.proto 

    Signed-off-by: Sergii Tkachenko <[email protected]>
    @sergiitk
    sergiitk committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1e711e9 View commit details
    Browse the repository at this point in the history

  3. Add cel.dev/expr to go.mod 

    Signed-off-by: Sergii Tkachenko <[email protected]>
    @sergiitk
    sergiitk committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    60b8586 View commit details
    Browse the repository at this point in the history