Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] repo: Add buf linting #47

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] repo: Add buf linting #47

wants to merge 1 commit into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 24, 2022

initially just for unused imports

Fix #45

Signed-off-by: Ryan Northey [email protected]

initially just for unused imports

Fix cncf#45

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax changed the title repo: Add buf linting [WIP] repo: Add buf linting Jun 24, 2022
@phlax phlax marked this pull request as draft June 24, 2022 11:03
@@ -2,6 +2,9 @@

set -e

bazel run @com_github_bufbuild_buf//:bin/buf lint -- --path xds
bazel run @com_github_bufbuild_buf//:bin/buf lint -- --path udpa
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to figure how/where best to run this

name = "buf",
srcs = [
"@com_github_bufbuild_buf//:bin/buf",
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envoy setup is tagged manual - might want to do the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buf linting
1 participant