Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations: add wip for messages and fields #11

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

mattklein123
Copy link
Contributor

Part of envoyproxy/envoy#17920

Signed-off-by: Matt Klein [email protected]

Copy link
Contributor

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change suggestion, but otherwise looks good.

udpa/annotations/status.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the s/udpa/xds/.

Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
@mattklein123
Copy link
Contributor Author

@htuch @markdroth this should be ready to go, thanks.

Signed-off-by: Matt Klein <[email protected]>
Copy link
Contributor

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants