Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the projects import to use the new landscape2 API #591

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

cjyabraham
Copy link
Contributor

@cjyabraham cjyabraham commented Jan 28, 2024

As per #589

This can be tested by running python updateprojects.py from inside of /.github/workflows and observing the effects on /website/data/projects.json.

@cjyabraham cjyabraham marked this pull request as ready for review January 28, 2024 09:31
@cjyabraham cjyabraham requested a review from aliok January 28, 2024 09:32
@aliok
Copy link
Member

aliok commented Jan 31, 2024

Added a suggestion above to clarify the break (it took me a minute to understand it 😆 )

Tested the python script, and checked the website if the newly produced json file is usable.
All good, thanks!

Co-authored-by: Ali Ok <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham cjyabraham merged commit 193eb22 into main Jan 31, 2024
2 checks passed
@cjyabraham cjyabraham deleted the ll22 branch January 31, 2024 07:49
@aliok aliok mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants