Add a comment-like entry in projects.json #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
aliok
force-pushed
the
2024-01-13-comment-in-projects-json-file
branch
from
9bc18eb to
48d7395
Compare
cjyabraham
approved these changes
Jan 13, 2024
|
This is great, thanks! I've worked mostly with YAML files, and I had no idea until now that comments weren't supported within JSON files! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574
Although this is not an ideal solution, since we can't add a comment to a JSON file, I've modified the Python script to add an entry at the top that looks like a comment. See
projects.jsonin the changed files.That entry is ignored in the https://contribute.cncf.io/contributors/projects/ page as the
project(graduation level) doesn't match anything.https://deploy-preview-577--cncf-contribute.netlify.app/contributors/projects/ still works fine and is not affected.
The only problem that can happen is that if there are any people who fetch this file for their own purposes. In that case, they would have to adapt their automation.