Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pacoxu and windsonsea to glossary collaborator #769

Closed
wants to merge 1 commit into from

Conversation

pacoxu
Copy link

@pacoxu pacoxu commented Dec 20, 2024

I want to submit a sync PR from zh to main and failed for not being a cncf/glossary#3145.

See cncf/glossary#3038 which is my original PR.

/cc @cjyabraham

Copy link

clowarden bot commented Dec 20, 2024

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user windsonsea is now a collaborator (role: write) of repository glossary
  • user pacoxu is now a collaborator (role: write) of repository glossary

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@iamNoah1
Copy link
Contributor

@pacoxu adding someone to cncf people is only required if they are going to be approving PRs. I am not sure if this is the case for you guys. However, your use case merging dev-zh in main or vice versa should be able to be done by creating a respective PR in that repo. Everyone should be able to open PRs. If not please let us know and maybe add some screenshots. We can close this.

@pacoxu
Copy link
Author

pacoxu commented Dec 21, 2024

https://github.com/cncf/glossary/compare/cncf:main...cncf:dev-zh?expand=1 we have no permission to open pr to merge zh to main.

And both of us want to be the zh-ch approver if we can.

@seokho-son
Copy link
Contributor

Hello, @pacoxu,

Thank you for your interest in the Glossary project and ZH localization. This matter is not something to be handled within cncf/people initially. Instead, it should first be discussed and resolved within the Glossary project itself.

The Glossary project has localization teams for each language (Slack channels, development branches, approvers), and the current approvers for the ZH localization are listed here:
https://github.com/cncf/glossary/blob/main/CODEOWNERS#L74

These approvers were either proposed when the ZH localization team was first formed or later included based on their significant contributions to the Glossary project or proposals by the team. The approvers are also registered as Glossary collaborators, which is necessary when opening PRs across branches. Write permissions are one of the higher-level permissions in the repository, so they cannot be granted to everyone. As you know, write permissions are not required to open general localization PRs.

Therefore, as a first step, I suggest requesting the current approvers to merge or update the branch into the main branch. (If this is a one-time update, I can assist with it directly.)

Alternatively, you can obtain consent from the existing approvers to become an approver or reviewer for dev-zh yourself. This requires demonstrating that you are qualified to be an approver. This means you must have made sufficient contributions to the community or clearly possess the necessary expertise. This process can be initiated by opening an issue or PR in cncf/glossary. (Please refer to the Policy for Localization Approvers: cncf/glossary#723)

@seokho-son
Copy link
Contributor

Comment to assist with updating the glossary main branch: cncf/glossary#3145 (comment)

@cjyabraham
Copy link
Contributor

Closing this PR since the issue is being addressed within the Glossary repo.

@cjyabraham cjyabraham closed this Dec 23, 2024
@pacoxu
Copy link
Author

pacoxu commented Dec 24, 2024

@seokho-son Thanks for your detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants