Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#290: Updated config.yaml #296

Merged
merged 3 commits into from
Oct 5, 2023
Merged

#290: Updated config.yaml #296

merged 3 commits into from
Oct 5, 2023

Conversation

Ratangulati
Copy link
Contributor

set @andreuxxxx to read

@clowarden
Copy link

clowarden bot commented Oct 2, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user andreuxxxx role in repository landscape has been updated to read

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@onlydole onlydole added the ok-to-test Apply if PR is validated safe to test label Oct 2, 2023
@onlydole onlydole self-requested a review October 2, 2023 17:10
@onlydole
Copy link
Member

onlydole commented Oct 2, 2023

Howdy, @Ratangulati - can you sign off on this commit (https://github.com/cncf/people/pull/296/checks?check_run_id=17303062243) and then this should be good to go.

@clowarden
Copy link

clowarden bot commented Oct 2, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • repository apisnoop\ has been added (visibility: public)
    • Collaborators
      • BobyMCbobs: admin
      • olivercodes: write
      • Riaankl: maintain
      • mgdevstack: read
      • heyste: write
      • devaips: read
      • spiffxp: admin
      • hh: admin
      • amwat: admin
      • zachmandeville: admin
      • bernokl: maintain
      • cncf-ci: admin
  • user andreuxxxx role in repository landscape has been updated to read

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

onlydole
onlydole reviewed Oct 2, 2023
View reviewed changes
config.yaml Outdated Show resolved Hide resolved
@clowarden
Copy link

clowarden bot commented Oct 3, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user andreuxxxx role in repository landscape has been updated to read

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@Ratangulati Ratangulati force-pushed the 290-update-landscape branch from 38f02ca to e7b8e20 Compare October 3, 2023 05:21
@clowarden
Copy link

clowarden bot commented Oct 3, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user andreuxxxx role in repository landscape has been updated to read

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@Ratangulati
Copy link
Contributor Author

Hey Taylor
I'd like to ask if you can put the label Hacktoberfest/Hacktoberfest-accepted in the PR.
Thanks

@Ratangulati Ratangulati requested a review from onlydole October 3, 2023 18:25
@Ratangulati
Copy link
Contributor Author

@onlydole Please review my PR.

@Ratangulati Ratangulati marked this pull request as draft October 5, 2023 06:04
@Ratangulati Ratangulati marked this pull request as ready for review October 5, 2023 06:05
onlydole
onlydole approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@onlydole
Copy link
Member

onlydole commented Oct 5, 2023

@Ratangulati - at this time, we aren't participating with Hacktoberfest on this repository, but please let me know if you're interested in other repositories where teams are, and I can assist.

@onlydole onlydole merged commit de44777 into cncf:main Oct 5, 2023
@clowarden
Copy link

clowarden bot commented Oct 5, 2023

Reconciliation completed

✅ The reconciliation completed successfully and all changes have been applied across the services!

Changes applied

Github

  • user andreuxxxx role in repository landscape has been updated to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole onlydole approved these changes

Assignees
No one assigned
Labels
ok-to-test Apply if PR is validated safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ratangulati @onlydole