-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LFX: Add Volcano project for Term 01 - 2025 March - May #1335
Conversation
Signed-off-by: Monokaix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Monokaix!
@JesseStutler, could you approve or 👍 this PR to confirm your participation?
approve 👍 |
Thanks for that! I don't see that you are on the maintainers list @Monokaix or @JesseStutler (https://github.com/cncf/foundation/blob/fe3e1535ce86318c16df2164cded14e75f94404d/project-maintainers.csv#L485-L489). So we'll need an additional approval. @k82cn, @kevin-wangzefeng, @hzxuzhonghu, @Thor-wl, or @william-wang, could one of you also approve this PR to confirm that the project is on board with this mentorship? |
/lgtm Thanks very much :) |
Awesome, thanks @k82cn! I'll remove the hold now. We'll still need to resolve the conflicts before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, will wait for conflicts to be cleared before merging, or I can clear the conflicts before I start the next batch, probably tomorrow morning.
Signed-off-by: Nate W <[email protected]>
OK, i've merged it in. We'll load this into LFX platform tomorrow. |
Hi, team
This pr adds volcano project for LFX term 01 2025, thanks for your reviewing: )